UserDevfile API permissions #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 18, 2020
skabashnyuk
force-pushed
the
permissions2
branch
2 times, most recently
from
6964769
to
10f736d
Compare
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
skabashnyuk
force-pushed
the
permissions2
branch
from
10f736d
to
25a5090
Compare
sleshchenko
reviewed
Sep 8, 2020
| @@ -453,6 +484,12 @@ private void createTestData() | |||
| organizationResourcesDistributor.capResources( | |||
| childOrganization.getId(), | |||
| singletonList(new ResourceImpl(RamResourceType.ID, 1024, RamResourceType.UNIT))); | |||
|
|
|||
| userDevfileDao.create(devfile = TestObjectsFactory.createUserDevfile("id-dev1", "devfile1")); | |||
There was a problem hiding this comment.
I suppose it's meant to be:
Suggested change
| userDevfileDao.create(devfile = TestObjectsFactory.createUserDevfile("id-dev1", "devfile1")); | |
| prepareCreator(user.getId()); | |
| userDevfileDao.create(devfile = TestObjectsFactory.createUserDevfile("id-dev1", "devfile1")); |
sleshchenko
reviewed
Sep 8, 2020
| CREATE INDEX che_index_userdevfile_permissions_actions_userdevfile_id ON che_userdevfile_permissions_actions (userdevfile_permissions_id); | ||
| -- constraints | ||
| ALTER TABLE che_userdevfile_permissions_actions ADD CONSTRAINT che_fk_userdevfile_permissions_actions_id FOREIGN KEY (userdevfile_permissions_id) REFERENCES che_userdevfile_permissions(id); | ||
| -------------------------------------------------------------------------------- |
There was a problem hiding this comment.
Suggested change
| -------------------------------------------------------------------------------- | |
| -------------------------------------------------------------------------------- | |
| -------------------------------------------------------------------------------- | ||
|
|
||
|
|
||
| -- Worker actions -------------------------------------------------------------- |
| public static final String READ = "read"; | ||
| public static final String DELETE = "delete"; | ||
| public static final String UPDATE = "update"; | ||
| public static final String DOMAIN_ID = "userDevfile"; |
There was a problem hiding this comment.
that's visible thing thought API and as we agreed - use just devfile for visible things
Suggested change
| public static final String DOMAIN_ID = "userDevfile"; | |
| public static final String DOMAIN_ID = "devfile"; |
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
|
closing in favor eclipse-che#17843 |
1 similar comment
|
closing in favor eclipse-che#17843 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
UserDevfile API permissions
Add permission to eclipse-che#17009
What issues does this PR fix or reference?
eclipse-che#16981