Skip to content

Commit

Permalink
Preparations for submission to CRAN (v0.4.5)
Browse files Browse the repository at this point in the history
  • Loading branch information
sjentsch committed May 22, 2024
1 parent 26357f7 commit 03e8023
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .prepare4CRAN
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ covr::codecov(token = "821f2b2f-e305-49b2-ab96-7f328530f6ed") # jTransform
# REMEMBER: error messages from R are not always pointing to the place where the error occurs - especially when using commands like build_readme()
# ================================================================================================================================================

# update version number in DESCRIPTION and NEWS.md (and changes in NEWS.md)
# update version number in DESCRIPTION and NEWS.md (and changes in NEWS.md)$(git log --date=format:'%Y-%m-%d' | grep -m1 "^Date" | sed 's/Date:\s*//')"
system("gedit DESCRIPTION NEWS.md inst/CITATION") # jmvReadWrite

# building / updating README, PDF manual, and the HTML documentation
Expand Down
1 change: 1 addition & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
* fixed a bug leading to an error in `write_omv` when columns where completely empty (i.e., if they contained
only NAs; incl. the respective unit tests)
* reduced cyclomatic complexity for `replace_omv`, `wide2long_omv`, and `jmvAtt`
* added workflow for `rhub`

---

Expand Down
17 changes: 10 additions & 7 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,19 @@
# CRAN Notes - jmvReadWrite

## Current version
0.4.5
* change long2wide_omv so that it to handle (omit) NAs when aggregating values (including unit tests)
0.4.6
* ensure that the `dataType` attribute is preserved / honoured by `write_omv` (earlier on, the data type
of a variable / column was determined by a logic and my have changed the class of this column)
* fixed a bug leading to an error in `write_omv` when columns where completely empty (i.e., if they contained
only NAs; incl. the respective unit tests)
* reduced cyclomatic complexity for `replace_omv`, `wide2long_omv`, and `jmvAtt`

## Test environments
* `devtools::check()`
- local (Ubuntu 22.04, R 4.3 x86_64-pc-linux-gnu): 0 errors, 0 warnings, 0 notes
* `devtools::check_rhub()`
- Ubuntu 20.04 R-release: 0 errors, 0 warnings, 1 note – missing “tidy” (checking HTML version of manual... → no command 'tidy' found)
- Fedora R-devel: 0 errors, 0 warnings, 1 note – missing “tidy” (checking HTML version of manual... → no command 'tidy' found)
- Windows 2022 Server R-devel: 0 errors, 0 warnings, 2 notes – because of leftover files (''NULL'', 'lastMiKTeXException')
- local (Ubuntu 22.04, R 4.4 x86_64-pc-linux-gnu): 0 errors, 0 warnings, 0 notes
* `rhub::rc_submit(platforms=c("linux", "windows", "macos", "macos-arm64"))`
- linux (r-devel), windows (r-devel), macos (r-devel), macos-arm64 (r-devel):
0 errors, 0 warnings, 2 notes (about files found in the main directory; but these files are correctly excluded in .Rbuildignore which rhub doesn't seem to honour)
* `devtools::check_win_devel()`
- status: 0 errors, 0 warnings, 0 notes (status: OK)

Expand Down

0 comments on commit 03e8023

Please sign in to comment.