Don't reset RichTextEditor document upon content prop changes, but do so with RichTextReadOnly
#98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to the discussion here #91, and should make the component more generally flexible, with the option for users to customize when/how they want to `setContent`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RichTextEditornow will not reset the editor's document content when itscontentprop changes. This should make the component more generally flexible, with the option for users to customize when/how they want tosetContent. See the new README section on "Re-rendering RichTextEditor when content changes" for more details and alternative approaches. (This is all related to the discussion here The cursor jumps to the end of the content when using React Hook Form #91 (comment).)RichTextReadOnlynow will reset the editor's document content when itscontentprop changes. This is how it should've worked all along, since it's read-only and should be treated as a more "pure" renderer.