Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rsg): Reparent does not add child to new parent #645

Merged
merged 1 commit into from
Apr 12, 2021
Merged

fix(rsg): Reparent does not add child to new parent #645

merged 1 commit into from
Apr 12, 2021

Conversation

underwoo16
Copy link
Contributor

Fixes #644

Fixed by calling appendChildToParent instead of setParent from reparent's implementation.

sjbarag
sjbarag approved these changes Apr 12, 2021
View reviewed changes
Copy link
Owner

@sjbarag sjbarag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent catch, @underwoo16 ! This looks perfect — thanks for the quick fix and clear description! 🎉

@sjbarag sjbarag changed the title Issues #644: Reparent does not add child to new parent fix(rsg): Reparent does not add child to new parent Apr 12, 2021
@sjbarag sjbarag added bug Any difference between this BrightScript implementation and RBI, or otherwise unexpected behavior scenegraph Affects this project's implementation of the SceneGraph framework labels Apr 12, 2021
@sjbarag sjbarag merged commit 0dca0af into sjbarag:main Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjbarag sjbarag sjbarag approved these changes

Assignees
No one assigned
Labels
bug Any difference between this BrightScript implementation and RBI, or otherwise unexpected behavior scenegraph Affects this project's implementation of the SceneGraph framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reparent (ifSGNodeChildren function) does not add child node to the new parent
2 participants
@underwoo16 @sjbarag