fix(lex): Allow JS object properties as identifiers #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using an identifier in a BrightScript file as an index into that object, we accidentally leaked non-Token properties on the `KeyWords` JS object from the lexer, e.g. `return KeyWords["constructor"]`. Use `hasOwnProperty()` to check if an identifier is a BrightScript keyword to avoid returning JavaScript internals as Tokens. fixes #613
sjbarag
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using an identifier in a BrightScript file as an index into that object, we accidentally leaked non-Token properties on the
KeyWordsJS object from the lexer, e.g.return KeyWords["constructor"]. UsehasOwnProperty()to check if an identifier is a BrightScript keyword to avoid returning JavaScript internals as Tokens.fixes #613