Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse stack trace #596

Merged
merged 2 commits into from
Dec 17, 2020
Merged

Reverse stack trace #596

merged 2 commits into from
Dec 17, 2020

Conversation

lkipke
Copy link
Collaborator

@lkipke lkipke commented Dec 17, 2020

Change summary

It probably makes more sense for the stack trace to be formatted so that the 0th element is the most recent. It allows for easier traversal for consumers. This also lines up with Javascript error stack, for example.

@lkipke lkipke added the bug Any difference between this BrightScript implementation and RBI, or otherwise unexpected behavior label Dec 17, 2020
@lkipke lkipke requested review from sjbarag and alimnios72 December 17, 2020 17:10
@lkipke lkipke self-assigned this Dec 17, 2020
Copy link
Owner

@sjbarag sjbarag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just rename the function to _brs_.getStackQueue() or _brs_.getEcartKcats()

Whoops! Thanks for the quick fix 😃

@lkipke lkipke merged commit 98c3f55 into sjbarag:main Dec 17, 2020
@lkipke lkipke deleted the reverse-stack-trace branch December 17, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Any difference between this BrightScript implementation and RBI, or otherwise unexpected behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants