Add global scope assignments #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since assignments in BrightScript take the place of declarations in most other languages, they need to be lower precedence (i.e. appear in the top-down grammar before statements). Since this grammar isn't being validated or used anywhere this is quite likely wrong and quite likely a moot effort, but I'm sticking with it for now gosh darnit!
This includes assignment *and* retrieval from global scope! BRS is now stateful.
Global variables currently take a copy-value approach, e.g.: ```brightscript a = 10 b = a a = "foo" print a ' "foo" print b ' 10 print a = b ' false ``` This will likely need to change once we implement associative arrays in BRS, but IIRC "copy-value" is correct for primitive values.
This language isn't very useful if you only get a REPL!
Rather than infinitely reporting an error at the same location (not very helpful), we should move on to the next statement boundary (only a ':' or newline so far) and continue parsing.
sjbarag
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users of BRS to create globally-scoped variables, assign values to them, and reference their stored values in other expressions and statements. It makes
brssignificantly more useful, because it can remember things!Global variables currently take a copy-value approach, e.g.:
This will likely need to change once we implement associative arrays in BRS, but IIRC "copy-value" is correct for primitive values.