Deprecate ugly function signature

sjahr · Aug 23, 2024 · 57a85c8 · 57a85c8
1 parent bbdb5b1
commit 57a85c8
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 13 deletions.
diff --git a/moveit_core/robot_model/include/moveit/robot_model/robot_model.h b/moveit_core/robot_model/include/moveit/robot_model/robot_model.h
@@ -246,13 +246,17 @@ class RobotModel
   bool hasLinkModel(const std::string& name) const;
 
   /** \brief Get a link by its name. Output error and return nullptr when the link is missing. */
-  const LinkModel* getLinkModel(const std::string& link, bool* has_link = nullptr) const;
+  const LinkModel* getLinkModel(const std::string& link) const;
+  [[deprecated("Use getLinkModel(const std::string& name) instead.")]] const LinkModel*
+  getLinkModel(const std::string& link, bool* has_link) const;
 
   /** \brief Get a link by its index. Output error and return nullptr when the link is missing. */
   const LinkModel* getLinkModel(size_t index) const;
 
   /** \brief Get a link by its name. Output error and return nullptr when the link is missing. */
-  LinkModel* getLinkModel(const std::string& link, bool* has_link = nullptr);
+  LinkModel* getLinkModel(const std::string& link);
+  [[deprecated("Use getLinkModel(const std::string& name) instead.")]] LinkModel*
+  getLinkModel(const std::string& link, bool* has_link = nullptr);
 
   /** \brief Get the latest link upwards the kinematic tree, which is only connected via fixed joints
    *

diff --git a/moveit_core/robot_model/src/robot_model.cpp b/moveit_core/robot_model/src/robot_model.cpp
@@ -1331,7 +1331,8 @@ JointModel* RobotModel::getJointModel(const std::string& name)
 
 const LinkModel* RobotModel::getLinkModel(const std::string& name, bool* has_link) const
 {
-  return const_cast<RobotModel*>(this)->getLinkModel(name, has_link);
+  *has_link = false;
+  return const_cast<RobotModel*>(this)->getLinkModel(name);
 }
 
 const LinkModel* RobotModel::getLinkModel(size_t index) const
@@ -1347,20 +1348,22 @@ const LinkModel* RobotModel::getLinkModel(size_t index) const
 
 LinkModel* RobotModel::getLinkModel(const std::string& name, bool* has_link)
 {
-  if (has_link)
-    *has_link = true;  // Start out optimistic
   LinkModelMap::const_iterator it = link_model_map_.find(name);
   if (it != link_model_map_.end())
-    return it->second;
-
-  if (has_link)
   {
-    *has_link = false;  // Report failure via argument
+    return it->second;
   }
   RCLCPP_ERROR(getLogger(), "Link '%s' not found in model '%s'", name.c_str(), model_name_.c_str());
   return nullptr;
 }
 
+const LinkModel* getLinkModel(const std::string& link, bool* has_link) const
+{
+  RCLCPP_ERROR(getLogger(), "'has_link' argument is deprecated. Use getLinkModel(const std::string& name) instead.");
+  *has_link = false;
+  return getLinkModel(link);
+}
+
 const LinkModel* RobotModel::getRigidlyConnectedParentLinkModel(const LinkModel* link)
 {
   if (!link)

diff --git a/moveit_core/robot_state/src/robot_state.cpp b/moveit_core/robot_state/src/robot_state.cpp
@@ -1344,8 +1344,9 @@ const Eigen::Isometry3d& RobotState::getFrameInfo(const std::string& frame_id, c
     frame_found = true;
     return IDENTITY_TRANSFORM;
   }
-  if ((robot_link = robot_model_->getLinkModel(frame_id, &frame_found)))
+  if ((robot_link = robot_model_->getLinkModel(frame_id)))
   {
+    frame_found = true;
     assert(checkLinkTransforms());
     return global_link_transforms_[robot_link->getLinkIndex()];
   }

diff --git a/moveit_kinematics/ikfast_kinematics_plugin/templates/ikfast61_moveit_plugin_template.cpp b/moveit_kinematics/ikfast_kinematics_plugin/templates/ikfast61_moveit_plugin_template.cpp
@@ -389,9 +389,8 @@ bool IKFastKinematicsPlugin::computeRelativeTransform(const std::string& from, c
   robot_state = std::make_shared<RobotState>(robot_model_);
   robot_state->setToDefaultValues();
 
-  bool has_link;  // to suppress RCLCPP_ERRORs for non-existent frames
-  auto* from_link = robot_model_->getLinkModel(from, &has_link);
-  auto* to_link = robot_model_->getLinkModel(to, &has_link);
+  auto* from_link = robot_model_->getLinkModel(from);
+  auto* to_link = robot_model_->getLinkModel(to);
   if (!from_link || !to_link)
     return false;