-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change behaviour of comment
argument of setter functions
#214
Milestone
Comments
Actually, I think we should just get rid of those comment arguments altogether and require people to put the comment directly on the value that they are setting. So instead of
we'll have
We do however need to create a mechanism for going back to using the species_params. I propose that
should prompt a calculation of the search volume from the species parameters. |
gustavdelius
added a commit
that referenced
this issue
Aug 21, 2021
gustavdelius
added a commit
that referenced
this issue
Aug 21, 2021
gustavdelius
added a commit
that referenced
this issue
Aug 21, 2021
gustavdelius
added a commit
that referenced
this issue
Aug 21, 2021
gustavdelius
added a commit
that referenced
this issue
Aug 21, 2021
gustavdelius
added a commit
that referenced
this issue
Aug 24, 2021
gustavdelius
added a commit
that referenced
this issue
Aug 24, 2021
gustavdelius
added a commit
that referenced
this issue
Aug 24, 2021
…o now it is possible to reset back to standard kernel.
gustavdelius
added a commit
that referenced
this issue
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For example for
setSearchVolume()
the documentation of thecomment
argument currently says:This is not very practical, because one may well want to change an existing comment. So the behaviour should be changed to:
The text was updated successfully, but these errors were encountered: