Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve reproduction parameters during tuning. #208

Closed
gustavdelius opened this issue Aug 12, 2021 · 2 comments · Fixed by #210
Closed

Preserve reproduction parameters during tuning. #208

gustavdelius opened this issue Aug 12, 2021 · 2 comments · Fixed by #210
Labels
discussion An idea that needs discussion before becoming a proposal enhancement New feature requests or suggestions for enhancement of existing features setting parameters Issue relates to the part of mizer used for setting up MizerParams objects.
Milestone

Comments

@gustavdelius
Copy link
Member

Originally I had envisaged the tuning process as a two-step process:

  1. Tune species_parameters so that the steady state agrees with averaged observations
  2. Tune the non-linearities in the model to give agreement with time-series data.

Therefore the functions that are designed to support step 1, like steady() and tuneParams(), used to switch off density dependence in reproduction for simplicity, given that it would need to be changed in step 2 anyway.

@Kenhasteandersen and @juliablanchard have now argued that it would be nice to set R_max already during step 1 of the process and to have it preserved by the tuning tools. While I don't understand the benefit of setting R_max already during step 1, I can see the benefit of having reproduction parameters preserved by the step 1 tools just in case someone has a need to re-visit step 1 after having already done some work on step 2.

So I propose a preserve argument to steady() and tuneParams() which can be set to "R_max" if the original R_max should be reinstated at the end of the functions. I prefer the preserve = "R_max" syntax to preserve_R_max = TRUE because it could possibly be extended in the future to allow requests for preservation of other parameters during the tuning.

@gustavdelius gustavdelius added enhancement New feature requests or suggestions for enhancement of existing features setting parameters Issue relates to the part of mizer used for setting up MizerParams objects. discussion An idea that needs discussion before becoming a proposal labels Aug 12, 2021
@gustavdelius gustavdelius added this to the Version 2.3 milestone Aug 12, 2021
gustavdelius added a commit that referenced this issue Aug 12, 2021
@gustavdelius
Copy link
Member Author

Of course preserving R_max may not always be possible. For example in the tuneParams() app the user might increase the abundance of a species to a value that requires a higher reproduction rate than that set by R_max. In that case I believe the user should be issued with a warning and the R_max should be increased to just a tiny bit above the minimum required value.

gustavdelius added a commit to sizespectrum/mizerExperimental that referenced this issue Aug 12, 2021
@gustavdelius
Copy link
Member Author

I have now implemented this in mizerExperimental, ready for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion An idea that needs discussion before becoming a proposal enhancement New feature requests or suggestions for enhancement of existing features setting parameters Issue relates to the part of mizer used for setting up MizerParams objects.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant