Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plotGrowthCurves() should preserve order of species #201

Closed
gustavdelius opened this issue Jul 25, 2021 · 3 comments
Closed

plotGrowthCurves() should preserve order of species #201

gustavdelius opened this issue Jul 25, 2021 · 3 comments
Assignees
@baldrech
Labels
bug minor effort Resolving this issue will involve a minor effort plots Issue relates to plotting functionality
Milestone
Version 3.0

Comments

@gustavdelius
Copy link
Member

When plotGrowthCurves() creates a panel of growth curves, these are not ordered in the way the species are ordered in the params object.
@gustavdelius gustavdelius added bug plots Issue relates to plotting functionality minor effort Resolving this issue will involve a minor effort labels Jul 25, 2021
@gustavdelius gustavdelius added this to the Version 2.3 milestone Aug 12, 2021
@gustavdelius
Copy link
Member Author

Furthermore, the species argument is ignored.

gustavdelius added a commit that referenced this issue Aug 15, 2021
@gustavdelius
Now plotGrowthCurves() with species_panel = TRUE respects `specie…
f08b74c 
…s` argument. Partially addressing #201
@gustavdelius
Copy link
Member Author

O.k. I have just pushed a fix for the second problem. @baldrech , can I let you fix the problem with the ordering of the panels? Given that you wrote the code you can probably do that the fastest.

@gustavdelius
Copy link
Member Author

After waiting for 20 days I have now fixed this myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baldrech baldrech

Labels
bug minor effort Resolving this issue will involve a minor effort plots Issue relates to plotting functionality
Projects
None yet
Milestone
Version 3.0
Development

No branches or pull requests
2 participants
@gustavdelius @baldrech