Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve escaping content for database primary key, relation, and rollup fields #13704

Closed
TCOTC opened this issue Jan 2, 2025 · 23 comments
Closed

Improve escaping content for database primary key, relation, and rollup fields #13704

TCOTC opened this issue Jan 2, 2025 · 23 comments
Assignees
@88250 @Vanessa219
Labels
Enhancement
Milestone
3.1.20

Comments

@TCOTC
Copy link
Contributor

TCOTC commented Jan 2, 2025 •
edited by 88250
Loading

改进数据块主键、关联、汇总转义

目前存在的问题：

  1. 点一下主键就会刷新整个数据库。
  2. 清空主键内容后会有一小段时间空白，然后才显示绑定块内容。应该要立即更新
video.webm
@88250
Copy link
Member

88250 commented Jan 2, 2025

这两个问题目前无法改进了，感谢反馈。

@88250 88250 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 2, 2025
@TCOTC
Copy link
Contributor Author

TCOTC commented Jan 11, 2025

我感觉不对啊，为什么会无法改进？

@88250
Copy link
Member

88250 commented Jan 11, 2025

现在实现上都是全部刷新的

@TCOTC
Copy link
Contributor Author

TCOTC commented Jan 11, 2025

现在只有主键有这个问题，其他字段都是判断内容有修改才会更新的

@88250
Copy link
Member

88250 commented Jan 11, 2025

我试了下，只有绑定块的主键会有这个问题？

@TCOTC
Copy link
Contributor Author

TCOTC commented Jan 11, 2025

对

@Vanessa219
Copy link
Member

Vanessa219 commented Jan 12, 2025 •
edited
Loading

清空的话需要调用接口获取原有数据，无法处理数据变化
目前还有两个问题 @88250

  1. 主键无 icon
  2. 主键转义

@Vanessa219 Vanessa219 reopened this Jan 12, 2025
@Vanessa219
Copy link
Member

2322e72

@TCOTC
Copy link
Contributor Author

TCOTC commented Jan 12, 2025

确实，绑定的文档少了那个默认图标

image

@Vanessa219
Copy link
Member

默认图标是不显示的。

@TCOTC
Copy link
Contributor Author

TCOTC commented Jan 12, 2025 •
edited
Loading

不显示的话没法切换图标。有的自动化流程会依赖切换图标，所以需要有图标才行

@Vanessa219
Copy link
Member

其他的也没显示，否则会有过多重复

Vanessa219 added a commit that referenced this issue Jan 12, 2025
@Vanessa219
🎨 #13704
06fe73f
@Vanessa219 Vanessa219 changed the title 改进数据库绑定块主键编辑 改进数据块主键转义 Jan 12, 2025
@TCOTC
Copy link
Contributor Author

TCOTC commented Jan 12, 2025 •
edited
Loading

我刚刚看了支持切换图标的 Notion 和 FlowUs，数据库里的文档都会显示默认图标

image

image

@88250 88250 self-assigned this Jan 12, 2025
88250 added a commit that referenced this issue Jan 12, 2025
@88250
🎨 Improve escaping database block content #13704
811399e
@Vanessa219 Vanessa219 added this to the 3.1.20 milestone Jan 12, 2025
@Vanessa219 Vanessa219 changed the title 改进数据块主键转义 改进数据块主键、关联、汇总转义 Jan 12, 2025
Vanessa219 added a commit that referenced this issue Jan 12, 2025
@Vanessa219
🎨 #13704
997be84
Vanessa219 added a commit that referenced this issue Jan 12, 2025
@Vanessa219
🎨 #13704
c6e06b9
@Vanessa219
Copy link
Member

奇怪了，我这里没有呀
image

@TCOTC
Copy link
Contributor Author

TCOTC commented Jan 12, 2025

文档中要有内容的才算是个文档，没有内容的就只是相当于思源的纯文本主键

@88250 88250 mentioned this issue Jan 12, 2025
Closed
@88250
Copy link
Member

88250 commented Jan 12, 2025

@Vanessa219 加一个相关转义问题 #13799

@88250 88250 changed the title 改进数据块主键、关联、汇总转义 Improve escaping content for database primary key, relation, and rollup fields Jan 13, 2025
@Vanessa219
Copy link
Member

目前有块和文档，没有就统一不加了。

Vanessa219 added a commit that referenced this issue Jan 14, 2025
@Vanessa219
🎨 #13704
c4c656c
Vanessa219 added a commit that referenced this issue Jan 14, 2025
@Vanessa219
🎨 #13704
e55214d
@TCOTC
Copy link
Contributor Author

TCOTC commented Jan 14, 2025

感觉还是加上好点，不需要的用户也能用 CSS 隐藏

@TCOTC
Copy link
Contributor Author

TCOTC commented Jan 15, 2025

这个转义还是比较怪：

video.webm

@Vanessa219
Copy link
Member

Vanessa219 commented Jan 16, 2025 •
edited
Loading

除文档块是没有 emoji 的，没有办法都加

@88250 看一下转义问题。

@88250
Copy link
Member

88250 commented Jan 16, 2025

转义已改。

88250 added a commit that referenced this issue Jan 16, 2025
@88250
🎨 Improve escaping content for database primary key, relation, and ro…
e26bcfa 
…llup fields #13704
@TCOTC
Copy link
Contributor Author

TCOTC commented Jan 16, 2025

除文档块是没有 emoji 的，没有办法都加

只要文档块加上就行了。比如我的数据库几乎不会绑定其他内容块。

@TCOTC
Copy link
Contributor Author

TCOTC commented Jan 17, 2025

关联字段都显示文档图标了，我觉得主键也应该显示：

Image

EightDoor added a commit to EightDoor/siyuan that referenced this issue Jan 22, 2025
@EightDoor
Merge commit '2ee69394da22d5cdbd30ae46b36f0bb4c8e15de4'
ffd6cb1 
* commit '2ee69394da22d5cdbd30ae46b36f0bb4c8e15de4': (101 commits)
  🔖 Release v3.1.20
  🎨 PNPM Lint
  📝 Update changelogs
  📝 Improve the user guide
  📝 Improve User Guide (siyuan-note#13825)
  🎨 siyuan-note#13793
  🎨 Improve workspace path checking siyuan-note#7569
  🎨 siyuan-note#13677
  🎨 siyuan-note#13801
  🎨 siyuan-note#13796
  🎨 siyuan-note#13735
  🎨 siyuan-note#13704
  🎨 Supports setting keep-alive notification text on Android siyuan-note#13815
  🎨 Improve the user guide
  🎨 siyuan-note#13704
  🎨 Backlink count at the doc block title including sub-blocks siyuan-note#13791
  🎨 Improve tree block stat siyuan-note#13811
  🎨 Improve text
  🎨 Backlink count at the doc block title including sub-blocks siyuan-note#13791
  🎨 siyuan-note#13791
  ...
@Vanessa219 Vanessa219 mentioned this issue Jan 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@88250 88250

@Vanessa219 Vanessa219

Labels
Enhancement
Projects
None yet
Milestone
3.1.20
Development

No branches or pull requests
3 participants
@88250 @Vanessa219 @TCOTC