feat: reorder environment variables in k8s django config #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rearranged the order in which the environment variables are loaded in the Kubernetes configuration file for Django. Environment variables will now be loaded from 'app-config' ConfigMap first, followed by the 'secrets-config'. This allows the local secrets config to override the app-config and not the other way around.
rochecompaan
approved these changes
Aug 22, 2024
- Move the reference to the 'secrets-config' secret after the reference to the 'app-config' configMap. - This change ensures that settings from 'secrets-config' can override values from 'app-config'. - Fix the configuration ordering in the Django kubernetes deployment file.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 21, 2024
## [1.15.0](v1.14.0...v1.15.0) (2024-09-21) ### Features * added local registry support and improved setup (close [#353](#353)) ([32de8c7](32de8c7)) * Gfranxman/313 prefer dotlocalbin as install location ([#342](#342)) ([dbb3556](dbb3556)) * implement s3 storage for static and media files on production ([#339](#339)) ([76afd23](76afd23)) * implement scaf challenge for session recording ([#379](#379)) ([0c091af](0c091af)) * **install.sh:** force re-download of Scaf on each install ([#338](#338)) ([f7ef3e3](f7ef3e3)) * op inject secrets (close [#368](#368)) ([58090b5](58090b5)) * reorder environment variables in k8s django config ([#350](#350)) ([f2cb234](f2cb234)) * script to test cookiecutter part of Scaf ([952e276](952e276)) ### Bug Fixes * Fixes frontend tests ([#363](#363)) ([4a2a5b2](4a2a5b2)) * mailhog port config (closes [#249](#249)) ([cea1602](cea1602)) * Specify the full container path, including the host. ([#309](#309)) ([2fa7276](2fa7276)), closes [#308](#308) * Update logo ([#373](#373)) ([afe2d84](afe2d84)) * use GitHub token for semantic release workflow ([b5eef60](b5eef60)) ### Documentation * add disk space warning to README ([#385](#385)) ([4262b2d](4262b2d)) * update related to optional GraphQL ([#366](#366)) ([92bfc8d](92bfc8d)), closes [#290](#290)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rearranged the order in which the environment variables are loaded in the Kubernetes configuration file for Django.
Environment variables will now be loaded from 'app-config' ConfigMap first, followed by the 'secrets-config'.
This allows the local secrets config to override the app-config and not the other way around.