Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not change the ownership of the bind mounted directory #413

Closed
calvinhp opened this issue Oct 30, 2024 · 1 comment
Closed

Do not change the ownership of the bind mounted directory #413

calvinhp opened this issue Oct 30, 2024 · 1 comment
Labels
released

Comments

@calvinhp
Copy link
Member

Since we have fixed the containers to now correctly run as the same UID and GID of the system's user, we should not work around the previous problem anymore. This is potentially dangerous and could lead to locking the current user out of their own account.

The entrypoint script here does a chown to make sure the scaf user inside of the running container can write out to the systems filesystem using the same UID and GID.

https://github.com/sixfeetup/scaf/blob/abd3b649852e7bccced5d5fbc38147e4a3f4280a/entrypoint.sh#L75C1-L76C1
calvinhp added a commit that referenced this issue Oct 30, 2024
@calvinhp
Do not change the ownership of the bind mounted directory
9dd5caf 
Related to #413

Removed extraneous and potentially dangerous operation done in the scaf container

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/sixfeetup/scaf/issues/413?shareId=XXXX-XXXX-XXXX-XXXX).
@calvinhp calvinhp mentioned this issue Oct 30, 2024
Merged
github-actions bot pushed a commit that referenced this issue Oct 30, 2024
@semantic-release-bot
chore(release): 1.17.2 [skip ci]
1211e78 
## [1.17.2](v1.17.1...v1.17.2) (2024-10-30)

### Bug Fixes

* Do not change the ownership of the bind mounted directory ([#414](#414)) ([2b4469e](2b4469e)), closes [#413](#413)

### Documentation

* change readme structure ([#369](#369)) ([abd3b64](abd3b64)), closes [#365](#365)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 1.17.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@calvinhp