Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement s3 storage for static and media files on production #339

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

gfranxman
Copy link
Member

  • Changed DEFAULT_FILE_STORAGE and STATICFILES_STORAGE from local to S3 in production settings.
  • Renamed utility 'storages.py' to 'cloud_storage.py'.
  • Renamed classes in storage utility to reflect usage of S3 - 'StaticStorage' to 'S3StaticStorage' and 'MediaStorage' to 'S3MediaStorage'.

This was done primarily for clarity and to avoid name conflicts over the storages package.

- Changed DEFAULT_FILE_STORAGE and STATICFILES_STORAGE from local to S3 in production settings.
- Renamed utility 'storages.py' to 'cloud_storage.py'.
- Renamed classes in storage utility to reflect usage of S3 - 'StaticStorage' to 'S3StaticStorage'
and 'MediaStorage' to 'S3MediaStorage'.

This was done primarily for clarity and to avoid name conflicts over the storages package.
@daveoconnor daveoconnor merged commit 76afd23 into main Sep 5, 2024
4 checks passed
@daveoconnor daveoconnor deleted the gfranxman/223-avoid-storages-name-conflict branch September 5, 2024 00:19
github-actions bot pushed a commit that referenced this pull request Sep 21, 2024
## [1.15.0](v1.14.0...v1.15.0) (2024-09-21)

### Features

* added local registry support and improved setup (close [#353](#353)) ([32de8c7](32de8c7))
* Gfranxman/313 prefer dotlocalbin as install location ([#342](#342)) ([dbb3556](dbb3556))
* implement s3 storage for static and media files on production ([#339](#339)) ([76afd23](76afd23))
* implement scaf challenge for session recording ([#379](#379)) ([0c091af](0c091af))
* **install.sh:** force re-download of Scaf on each install ([#338](#338)) ([f7ef3e3](f7ef3e3))
* op inject secrets (close [#368](#368)) ([58090b5](58090b5))
* reorder environment variables in k8s django config ([#350](#350)) ([f2cb234](f2cb234))
* script to test cookiecutter part of Scaf ([952e276](952e276))

### Bug Fixes

* Fixes frontend tests ([#363](#363)) ([4a2a5b2](4a2a5b2))
* mailhog port config (closes [#249](#249)) ([cea1602](cea1602))
* Specify the full container path, including the host. ([#309](#309)) ([2fa7276](2fa7276)), closes [#308](#308)
* Update logo ([#373](#373)) ([afe2d84](afe2d84))
* use GitHub token for semantic release workflow ([b5eef60](b5eef60))

### Documentation

* add disk space warning to README ([#385](#385)) ([4262b2d](4262b2d))
* update related to optional GraphQL ([#366](#366)) ([92bfc8d](92bfc8d)), closes [#290](#290)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address name conflict in storages
3 participants