refactor: add Exception-suffix for exception-classes (#44)

src/main/java/com/sitepark/ies/contentrepository/core/domain/entity/Anchor.java

@@ -6,7 +6,7 @@
 import java.util.regex.Pattern;
 
 import com.fasterxml.jackson.annotation.JsonValue;
-import com.sitepark.ies.contentrepository.core.domain.exception.InvalidAnchor;
+import com.sitepark.ies.contentrepository.core.domain.exception.InvalidAnchorException;
 
 public final class Anchor implements Serializable {
 
@@ -49,16 +49,16 @@ public String getName() {
 	}
 
 	/**
-	 * @throws InvalidAnchor
+	 * @throws InvalidAnchorException
 	 */
 	private static void validate(String name) {
 
 		if (ONLY_NUMBERS_PATTERN.matcher(name).matches()) {
-			throw new InvalidAnchor(name, "Anchor must not only consist of numbers");
+			throw new InvalidAnchorException(name, "Anchor must not only consist of numbers");
 		}
 
 		if (!VALIDATOR_PATTERN.matcher(name).matches()) {
-			throw new InvalidAnchor(name, "Anchor contains Spaces");
+			throw new InvalidAnchorException(name, "Anchor contains Spaces");
 		}
 	}
 

src/main/java/com/sitepark/ies/contentrepository/core/domain/exception/AccessDeniedException.java

@@ -0,0 +1,14 @@
+package com.sitepark.ies.contentrepository.core.domain.exception;
+
+public class AccessDeniedException extends ContentRepositoryException {
+	private static final long serialVersionUID = 1L;
+
+	public AccessDeniedException(String message) {
+		super(message);
+	}
+
+	public AccessDeniedException(String message, Throwable t) {
+		super(message, t);
+	}
+
+}

src/main/java/com/sitepark/ies/contentrepository/core/domain/exception/AnchorAlreadyExists.java → src/main/java/com/sitepark/ies/contentrepository/core/domain/exception/AnchorAlreadyExistsException.java

@@ -2,15 +2,15 @@
 
 import com.sitepark.ies.contentrepository.core.domain.entity.Anchor;
 
-public class AnchorAlreadyExists extends ContentRepositoryException {
+public class AnchorAlreadyExistsException extends ContentRepositoryException {
 
 	private static final long serialVersionUID = 1L;
 
 	private final Anchor anchor;
 
 	private final long owner;
 
-	public AnchorAlreadyExists(Anchor anchor, long owner) {
+	public AnchorAlreadyExistsException(Anchor anchor, long owner) {
 		super();
 		this.anchor = anchor;
 		this.owner = owner;

src/main/java/com/sitepark/ies/contentrepository/core/domain/exception/AnchorNotFound.java → src/main/java/com/sitepark/ies/contentrepository/core/domain/exception/AnchorNotFoundException.java

@@ -2,13 +2,13 @@
 
 import com.sitepark.ies.contentrepository.core.domain.entity.Anchor;
 
-public class AnchorNotFound extends ContentRepositoryException {
+public class AnchorNotFoundException extends ContentRepositoryException {
 
 	private static final long serialVersionUID = 1L;
 
 	private final Anchor anchor;
 
-	public AnchorNotFound(Anchor anchor) {
+	public AnchorNotFoundException(Anchor anchor) {
 		super();
 		this.anchor = anchor;
 	}

src/main/java/com/sitepark/ies/contentrepository/core/domain/exception/EntityLocked.java → src/main/java/com/sitepark/ies/contentrepository/core/domain/exception/EntityLockedException.java

@@ -2,13 +2,13 @@
 
 import com.sitepark.ies.contentrepository.core.domain.entity.EntityLock;
 
-public class EntityLocked extends ContentRepositoryException {
+public class EntityLockedException extends ContentRepositoryException {
 
 	private static final long serialVersionUID = 1L;
 
 	private final EntityLock lock;
 
-	public EntityLocked(EntityLock lock) {
+	public EntityLockedException(EntityLock lock) {
 		super();
 		this.lock = lock;
 	}

src/main/java/com/sitepark/ies/contentrepository/core/domain/exception/EntityNotFound.java → src/main/java/com/sitepark/ies/contentrepository/core/domain/exception/EntityNotFoundException.java

@@ -1,12 +1,12 @@
 package com.sitepark.ies.contentrepository.core.domain.exception;
 
-public class EntityNotFound extends ContentRepositoryException {
+public class EntityNotFoundException extends ContentRepositoryException {
 
 	private static final long serialVersionUID = 1L;
 
 	private final long id;
 
-	public EntityNotFound(long id) {
+	public EntityNotFoundException(long id) {
 		super();
 		this.id = id;
 	}

src/main/java/com/sitepark/ies/contentrepository/core/domain/exception/GroupNotEmpty.java → src/main/java/com/sitepark/ies/contentrepository/core/domain/exception/GroupNotEmptyException.java

@@ -1,11 +1,11 @@
 package com.sitepark.ies.contentrepository.core.domain.exception;
 
-public class GroupNotEmpty extends ContentRepositoryException {
+public class GroupNotEmptyException extends ContentRepositoryException {
 	private static final long serialVersionUID = 1L;
 
 	private final long id;
 
-	public GroupNotEmpty(long id) {
+	public GroupNotEmptyException(long id) {
 		super();
 		this.id = id;
 	}

src/main/java/com/sitepark/ies/contentrepository/core/domain/exception/InvalidAnchor.java → src/main/java/com/sitepark/ies/contentrepository/core/domain/exception/InvalidAnchorException.java

@@ -1,12 +1,12 @@
 package com.sitepark.ies.contentrepository.core.domain.exception;
 
-public class InvalidAnchor extends ContentRepositoryException {
+public class InvalidAnchorException extends ContentRepositoryException {
 
 	private final String name;
 
 	private static final long serialVersionUID = 1L;
 
-	public InvalidAnchor(String name, String message) {
+	public InvalidAnchorException(String name, String message) {
 		super(message);
 		this.name = name;
 	}

src/main/java/com/sitepark/ies/contentrepository/core/domain/exception/ParentMissing.java → src/main/java/com/sitepark/ies/contentrepository/core/domain/exception/ParentMissingException.java

@@ -1,5 +1,5 @@
 package com.sitepark.ies.contentrepository.core.domain.exception;
 
-public class ParentMissing extends ContentRepositoryException {
+public class ParentMissingException extends ContentRepositoryException {
 	private static final long serialVersionUID = 1L;
 }

src/main/java/com/sitepark/ies/contentrepository/core/usecase/BulkPurge.java

@@ -17,8 +17,8 @@
 import com.sitepark.ies.contentrepository.core.domain.entity.EntityTree;
 import com.sitepark.ies.contentrepository.core.domain.entity.query.Query;
 import com.sitepark.ies.contentrepository.core.domain.entity.query.SubTreeQuery;
-import com.sitepark.ies.contentrepository.core.domain.exception.AccessDenied;
-import com.sitepark.ies.contentrepository.core.domain.exception.GroupNotEmpty;
+import com.sitepark.ies.contentrepository.core.domain.exception.AccessDeniedException;
+import com.sitepark.ies.contentrepository.core.domain.exception.GroupNotEmptyException;
 import com.sitepark.ies.contentrepository.core.port.AccessControl;
 import com.sitepark.ies.contentrepository.core.port.ContentRepository;
 import com.sitepark.ies.contentrepository.core.port.EntityBulkExecutor;
@@ -129,11 +129,11 @@ private void accessControl(List<Entity> entityList) {
 			long id = entity.getId().get();
 			if (entity.isGroup()) {
 				if (!this.accessControl.isGroupRemoveable(id)) {
-					throw new AccessDenied("Not allowed to remove group " + id);
+					throw new AccessDeniedException("Not allowed to remove group " + id);
 				}
 			} else {
 				if (!this.accessControl.isEntityRemovable(id)) {
-					throw new AccessDenied("Not allowed to remove entity " + id);
+					throw new AccessDeniedException("Not allowed to remove entity " + id);
 				}
 			}
 		});
@@ -203,7 +203,7 @@ private EntityBulkOperation buildPurgeOperation(List<Entity> entityList) {
 					long id = entity.getId().get();
 
 					if (this.repository.isGroup(id) && !this.repository.isEmptyGroup(id)) {
-						throw new GroupNotEmpty(id);
+						throw new GroupNotEmptyException(id);
 					}
 
 					if (LOGGER.isInfoEnabled()) {

src/main/java/com/sitepark/ies/contentrepository/core/usecase/PurgeEntity.java

@@ -5,8 +5,8 @@
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
 
-import com.sitepark.ies.contentrepository.core.domain.exception.AccessDenied;
-import com.sitepark.ies.contentrepository.core.domain.exception.GroupNotEmpty;
+import com.sitepark.ies.contentrepository.core.domain.exception.AccessDeniedException;
+import com.sitepark.ies.contentrepository.core.domain.exception.GroupNotEmptyException;
 import com.sitepark.ies.contentrepository.core.port.AccessControl;
 import com.sitepark.ies.contentrepository.core.port.ContentRepository;
 import com.sitepark.ies.contentrepository.core.port.EntityLockManager;
@@ -64,11 +64,11 @@ protected PurgeEntity(ContentRepository repository, EntityLockManager lockManage
 	public void purgeEntity(long id) {
 
 		if (!this.accessControl.isEntityRemovable(id)) {
-			throw new AccessDenied("Not allowed to remove entity " + id);
+			throw new AccessDeniedException("Not allowed to remove entity " + id);
 		}
 
 		if (this.repository.isGroup(id) && !this.repository.isEmptyGroup(id)) {
-			throw new GroupNotEmpty(id);
+			throw new GroupNotEmptyException(id);
 		}
 
 		try {

src/main/java/com/sitepark/ies/contentrepository/core/usecase/RecoverEntity.java

@@ -5,8 +5,8 @@
 import com.sitepark.ies.contentrepository.core.domain.entity.Entity;
 import com.sitepark.ies.contentrepository.core.domain.entity.HistoryEntryType;
 import com.sitepark.ies.contentrepository.core.domain.entity.RecycleBinItem;
-import com.sitepark.ies.contentrepository.core.domain.exception.AccessDenied;
-import com.sitepark.ies.contentrepository.core.domain.exception.EntityNotFound;
+import com.sitepark.ies.contentrepository.core.domain.exception.AccessDeniedException;
+import com.sitepark.ies.contentrepository.core.domain.exception.EntityNotFoundException;
 import com.sitepark.ies.contentrepository.core.port.AccessControl;
 import com.sitepark.ies.contentrepository.core.port.ContentRepository;
 import com.sitepark.ies.contentrepository.core.port.HistoryManager;
@@ -33,10 +33,10 @@ protected RecoverEntity(ContentRepository repository, HistoryManager historyMana
 	public void recover(long id) {
 
 		Optional<RecycleBinItem> recycleBinItem = this.recycleBin.get(id);
-		recycleBinItem.orElseThrow(() -> new EntityNotFound(id));
+		recycleBinItem.orElseThrow(() -> new EntityNotFoundException(id));
 
 		if (!this.accessControl.isGroupCreateable(recycleBinItem.get().getParent())) {
-			throw new AccessDenied("Not allowed to recover entity " + recycleBinItem.get().getId()
+			throw new AccessDeniedException("Not allowed to recover entity " + recycleBinItem.get().getId()
 					+ " in group " + recycleBinItem.get().getParent());
 		}
 

src/main/java/com/sitepark/ies/contentrepository/core/usecase/RemoveEntity.java

@@ -6,8 +6,8 @@
 import com.sitepark.ies.contentrepository.core.domain.entity.EntityLock;
 import com.sitepark.ies.contentrepository.core.domain.entity.HistoryEntryType;
 import com.sitepark.ies.contentrepository.core.domain.entity.RecycleBinItem;
-import com.sitepark.ies.contentrepository.core.domain.exception.AccessDenied;
-import com.sitepark.ies.contentrepository.core.domain.exception.EntityLocked;
+import com.sitepark.ies.contentrepository.core.domain.exception.AccessDeniedException;
+import com.sitepark.ies.contentrepository.core.domain.exception.EntityLockedException;
 import com.sitepark.ies.contentrepository.core.port.AccessControl;
 import com.sitepark.ies.contentrepository.core.port.ContentRepository;
 import com.sitepark.ies.contentrepository.core.port.EntityLockManager;
@@ -42,7 +42,7 @@ protected RemoveEntity(ContentRepository repository, EntityLockManager lockManag
 	public void remove(long id) {
 
 		if (!this.accessControl.isEntityRemovable(id)) {
-			throw new AccessDenied("Not allowed to remove entity " + id);
+			throw new AccessDeniedException("Not allowed to remove entity " + id);
 		}
 
 		Optional<Entity> entity = this.repository.get(id);
@@ -53,7 +53,7 @@ public void remove(long id) {
 		try {
 			Optional<EntityLock> lock = this.lockManager.getLock(id);
 			lock.ifPresent(l -> {
-				throw new EntityLocked(l);
+				throw new EntityLockedException(l);
 			});
 
 			this.searchIndex.remove(id);

src/main/java/com/sitepark/ies/contentrepository/core/usecase/StoreEntity.java

@@ -6,10 +6,10 @@
 import com.sitepark.ies.contentrepository.core.domain.entity.Entity;
 import com.sitepark.ies.contentrepository.core.domain.entity.EntityLock;
 import com.sitepark.ies.contentrepository.core.domain.entity.HistoryEntryType;
-import com.sitepark.ies.contentrepository.core.domain.exception.AccessDenied;
-import com.sitepark.ies.contentrepository.core.domain.exception.EntityLocked;
-import com.sitepark.ies.contentrepository.core.domain.exception.EntityNotFound;
-import com.sitepark.ies.contentrepository.core.domain.exception.ParentMissing;
+import com.sitepark.ies.contentrepository.core.domain.exception.AccessDeniedException;
+import com.sitepark.ies.contentrepository.core.domain.exception.EntityLockedException;
+import com.sitepark.ies.contentrepository.core.domain.exception.EntityNotFoundException;
+import com.sitepark.ies.contentrepository.core.domain.exception.ParentMissingException;
 import com.sitepark.ies.contentrepository.core.domain.service.ContentDiffer;
 import com.sitepark.ies.contentrepository.core.port.AccessControl;
 import com.sitepark.ies.contentrepository.core.port.ContentRepository;
@@ -54,12 +54,12 @@ public long store(Entity entity) {
 	private long create(Entity newEntity) {
 
 		Optional<Long> parent = newEntity.getParent();
-		parent.orElseThrow(() -> new ParentMissing());
+		parent.orElseThrow(() -> new ParentMissingException());
 
 		long parentId = parent.get();
 
 		if (!this.accessControl.isEntityCreateable(parentId)) {
-			throw new AccessDenied("Not allowed to create entity in group " + parent);
+			throw new AccessDeniedException("Not allowed to create entity in group " + parent);
 		}
 
 		long generatedId = this.idGenerator.generate();
@@ -84,16 +84,16 @@ private long update(Entity updateEntity) {
 		long id = updateEntity.getId().get();
 
 		Optional<Entity> existsEntity = this.repository.get(id);
-		existsEntity.orElseThrow(() -> new EntityNotFound(id));
+		existsEntity.orElseThrow(() -> new EntityNotFoundException(id));
 
 		if (!this.accessControl.isEntityWritable(id)) {
-			throw new AccessDenied("Not allowed to update entity " + id);
+			throw new AccessDeniedException("Not allowed to update entity " + id);
 		}
 
 		try {
 			Optional<EntityLock> lock = this.lockManager.getLock(id);
 			lock.ifPresent(l -> {
-				throw new EntityLocked(l);
+				throw new EntityLockedException(l);
 			});
 
 			ChangeSet changeSet = this.contentDiffer.diff(updateEntity, existsEntity.get());

src/test/java/com/sitepark/ies/contentrepository/core/usecase/PurgeEntityTest.java

@@ -12,8 +12,8 @@
 import org.mockito.InOrder;
 
 import com.sitepark.ies.contentrepository.core.domain.entity.EntityLock;
-import com.sitepark.ies.contentrepository.core.domain.exception.AccessDenied;
-import com.sitepark.ies.contentrepository.core.domain.exception.EntityLocked;
+import com.sitepark.ies.contentrepository.core.domain.exception.AccessDeniedException;
+import com.sitepark.ies.contentrepository.core.domain.exception.EntityLockedException;
 import com.sitepark.ies.contentrepository.core.port.AccessControl;
 import com.sitepark.ies.contentrepository.core.port.ContentRepository;
 import com.sitepark.ies.contentrepository.core.port.EntityLockManager;
@@ -44,7 +44,7 @@ void testAccessDenied() {
 				null,
 				null,
 				null);
-		assertThrows(AccessDenied.class, () -> {
+		assertThrows(AccessDeniedException.class, () -> {
 			purgeEntity.purgeEntity(10L);
 		});
 	}
@@ -58,7 +58,7 @@ void testEntityIsLocked() {
 		when(accessControl.isEntityRemovable(anyLong())).thenReturn(true);
 
 		EntityLockManager lockManager = mock(EntityLockManager.class);
-		doThrow(new EntityLocked(EntityLock.builder().entity(10L).build())).when(lockManager).lock(anyLong());
+		doThrow(new EntityLockedException(EntityLock.builder().entity(10L).build())).when(lockManager).lock(anyLong());
 
 		var purgeEntity = new PurgeEntity(
 				repository,
@@ -73,10 +73,10 @@ void testEntityIsLocked() {
 				null);
 		//purgeEntity.purgeEntity(10L);
 
-		EntityLocked entityLocked = assertThrows(EntityLocked.class, () -> {
+		EntityLockedException entityLockedException = assertThrows(EntityLockedException.class, () -> {
 			purgeEntity.purgeEntity(10L);
 		}, "entity should be locked");
-		assertEquals(10L, entityLocked.getLock().getEntity(), "unexpected entity id");
+		assertEquals(10L, entityLockedException.getLock().getEntity(), "unexpected entity id");
 	}
 
 	@SuppressWarnings("PMD")