refactor: fix pmd warnings

pom.xml

@@ -142,7 +142,7 @@
 		<dependency>
 			<groupId>nl.jqno.equalsverifier</groupId>
 			<artifactId>equalsverifier</artifactId>
-			<version>3.10.1</version>
+			<version>3.14.2</version>
 			<scope>test</scope>
 		</dependency>
 

src/main/java/com/sitepark/ies/contentrepository/core/domain/databind/DatabindModule.java

@@ -9,6 +9,6 @@ public class DatabindModule extends SimpleModule {
 	private static final long serialVersionUID = 1L;
 
 	public DatabindModule() {
-		this.addDeserializer(Filter.class, new FilterDeserializer());
+		super.addDeserializer(Filter.class, new FilterDeserializer());
 	}
 }

src/main/java/com/sitepark/ies/contentrepository/core/domain/entity/Entity.java

@@ -75,7 +75,6 @@ public final int hashCode() {
 		int hash = Long.hashCode(this.id);
 		hash = (this.anchor != null) ? 31 * hash + this.anchor.hashCode() : hash;
 		hash = (this.name != null) ? 31 * hash + this.name.hashCode() : hash;
-		hash = (this.anchor != null) ? 31 * hash + this.anchor.hashCode() : hash;
 		hash = 31 * hash + Long.hashCode(this.version);
 		hash = 31 * hash + Long.hashCode(this.parent);
 		hash = 31 * hash + Boolean.hashCode(this.isGroup);

src/main/java/com/sitepark/ies/contentrepository/core/domain/entity/EntityBulkExecution.java

@@ -47,7 +47,7 @@ public static class Builder {
 
 		private EntityBulkOperation finalizer;
 
-		private Builder() {
+		protected Builder() {
 		}
 
 		/**
@@ -63,6 +63,7 @@ public Builder topic(String... topic) {
 			return this;
 		}
 
+		@SuppressWarnings("PMD.UseArraysAsList")
 		public Builder operation(EntityBulkOperation... operations) {
 			assert operations != null;
 			for (EntityBulkOperation operation : operations) {

src/main/java/com/sitepark/ies/contentrepository/core/domain/entity/EntityBulkOperation.java

@@ -46,7 +46,7 @@ public static class Builder {
 
 		private Consumer<Entity> consumer;
 
-		private Builder() {
+		protected Builder() {
 		}
 
 		public Builder key(BulkOperationKey key) {

src/main/java/com/sitepark/ies/contentrepository/core/domain/entity/EntityLock.java

@@ -61,10 +61,10 @@ public static class Builder {
 		private long lastAccess;
 		private long ttl;
 
-		private Builder() {
+		protected Builder() {
 		}
 
-		private Builder(EntityLock entityLock) {
+		protected Builder(EntityLock entityLock) {
 			this.entity = entityLock.entity;
 			this.user = entityLock.user;
 			this.created = entityLock.created;

src/main/java/com/sitepark/ies/contentrepository/core/domain/entity/EntityTree.java

@@ -145,9 +145,9 @@ private void toString(int indent, Long parent, java.lang.StringBuilder indentPre
 				this.toString(indent, child, indentPrefix, b);
 			}
 		} else {
-			b.append(indentPrefix.toString());
-			b.append(this.index.get(parent));
-			b.append('\n');
+			b.append(indentPrefix.toString())
+				.append(this.index.get(parent))
+				.append('\n');
 
 			if (this.hasChildren(parent)) {
 				for (int i = 0; i < indent; i++) {

src/main/java/com/sitepark/ies/contentrepository/core/domain/entity/HistoryEntry.java

@@ -62,7 +62,7 @@ public Builder toBuilder() {
 		return new Builder(this);
 	}
 
-	public static class Builder {
+	public static final class Builder {
 
 		private long entity;
 		private String initiator;

src/main/java/com/sitepark/ies/contentrepository/core/domain/entity/RecycleBinItem.java

@@ -42,7 +42,7 @@ public Builder toBuilder() {
 		return new Builder(this);
 	}
 
-	public static class Builder {
+	public static final class Builder {
 
 		private long id;
 		private long parent;

src/main/java/com/sitepark/ies/contentrepository/core/domain/entity/RecycleBinItemFilter.java

@@ -35,7 +35,7 @@ public Builder toBuilder() {
 		return new Builder(this);
 	}
 
-	public static class Builder {
+	public static final class Builder {
 
 		private LocalDateTime from;
 		private LocalDateTime to;

src/main/java/com/sitepark/ies/contentrepository/core/domain/entity/filter/FilterDeserializer.java

@@ -8,16 +8,16 @@ public class FilterDeserializer extends UniquePropertyPolymorphicDeserializer<Fi
 
 	public FilterDeserializer() {
 		super(Filter.class);
-		this.register("id", Id.class);
-		this.register("idList", IdList.class);
-		this.register("parent", Parent.class);
-		this.register("parentList", ParentList.class);
-		this.register("root", Root.class);
-		this.register("rootList", RootList.class);
-		this.register("anchor", Anchor.class);
-		this.register("anchorList", AnchorList.class);
-		this.register("and", And.class);
-		this.register("or", Or.class);
-		this.register("not", Not.class);
+		super.register("id", Id.class);
+		super.register("idList", IdList.class);
+		super.register("parent", Parent.class);
+		super.register("parentList", ParentList.class);
+		super.register("root", Root.class);
+		super.register("rootList", RootList.class);
+		super.register("anchor", Anchor.class);
+		super.register("anchorList", AnchorList.class);
+		super.register("and", And.class);
+		super.register("or", Or.class);
+		super.register("not", Not.class);
 	}
 }

src/main/java/com/sitepark/ies/contentrepository/core/domain/entity/query/CursorBasedQuery.java

@@ -40,9 +40,9 @@ public static class Builder extends Query.Builder<Builder> {
 
 		private String after;
 
-		private Builder() { }
+		protected Builder() { }
 
-		private Builder(CursorBasedQuery curserBasedQuery) {
+		protected Builder(CursorBasedQuery curserBasedQuery) {
 			super(curserBasedQuery);
 			this.first = curserBasedQuery.first;
 			this.after = curserBasedQuery.after;

src/main/java/com/sitepark/ies/contentrepository/core/domain/entity/query/QueryOptions.java

@@ -24,10 +24,10 @@ public static class Builder {
 
 		private boolean showHidden;
 
-		private Builder() {
+		protected Builder() {
 		}
 
-		private Builder(QueryOptions queryOptions) {
+		protected Builder(QueryOptions queryOptions) {
 			this.showHidden = queryOptions.showHidden;
 		}
 

src/main/java/com/sitepark/ies/contentrepository/core/domain/entity/query/SubTreeQuery.java

@@ -35,9 +35,9 @@ public static class Builder extends Query.Builder<Builder> {
 
 		private final List<Long> rootList = new ArrayList<>();
 
-		private Builder() { }
+		protected Builder() { }
 
-		private Builder(SubTreeQuery curserBasedQuery) {
+		protected Builder(SubTreeQuery curserBasedQuery) {
 			super(curserBasedQuery);
 			this.rootList.addAll(curserBasedQuery.rootList);
 		}

src/main/java/com/sitepark/ies/contentrepository/core/domain/entity/sort/Name.java

@@ -21,11 +21,11 @@ public static Builder builder() {
 	@JsonPOJOBuilder(withPrefix = "", buildMethodName = "build")
 	public static class Builder extends OrderCriteria.Builder<Builder> {
 
-		private Builder() {
+		protected Builder() {
 			super();
 		}
 
-		private Builder(Name name) {
+		protected Builder(Name name) {
 			super(name);
 		}
 

src/main/java/com/sitepark/ies/contentrepository/core/domain/entity/sort/OrderBy.java

@@ -36,15 +36,17 @@ public static class Builder {
 
 		private final List<OrderCriteria> sort = new ArrayList<>();
 
-		private Builder() { }
+		protected Builder() { }
 
-		private Builder(OrderBy and) {
+		protected Builder(OrderBy and) {
 			this.sort.addAll(and.sort);
 		}
 
+		@SuppressWarnings("PMD.UseArraysAsList")
 		public Builder sort(OrderCriteria... sortCriteriaList) {
 			assert sortCriteriaList != null;
 			for (OrderCriteria sortCriteria : sortCriteriaList) {
+				assert sortCriteria != null : "sortCriteria is null";
 				this.sort.add(sortCriteria);
 			}
 			return this;

src/main/java/com/sitepark/ies/contentrepository/core/domain/exception/AnchorAlreadyExists.java

@@ -1,5 +1,32 @@
 package com.sitepark.ies.contentrepository.core.domain.exception;
 
+import com.sitepark.ies.contentrepository.core.domain.entity.Anchor;
+
 public class AnchorAlreadyExists extends ContentRepositoryException {
+
 	private static final long serialVersionUID = 1L;
+
+	private final Anchor anchor;
+
+	private final long owner;
+
+	public AnchorAlreadyExists(Anchor anchor, long owner) {
+		super();
+		this.anchor = anchor;
+		this.owner = owner;
+	}
+
+	public Anchor getAnchor() {
+		return this.anchor;
+	}
+
+	public long getOwner() {
+		return this.owner;
+	}
+
+	@Override
+	public String getMessage() {
+		return "Anchor " + this.anchor + " already exists for entity " + this.owner;
+	}
+
 }

src/main/java/com/sitepark/ies/contentrepository/core/usecase/BulkPurgeInput.java

@@ -44,7 +44,7 @@ public Builder toBuilder() {
 		return new Builder(this);
 	}
 
-	public static class Builder {
+	public static final class Builder {
 
 		private final List<Long> rootList = new ArrayList<>();