Problem: Repository::new_named_item duplicate check on aarch64

Tests pertaining to duplicate name fail in debug mode on aarch64, the OS error is never returned. Solution: use FastISel instead of GlobalISel Tracking issue has been filed with Rust: rust-lang/rust#50516
sit-fyi · May 17, 2018 · 38bfb95 · 38bfb95
1 parent 9a1c90d
commit 38bfb95
Show file tree

Hide file tree

Showing 10 changed files with 13 additions and 0 deletions.
diff --git a/.cargo/config b/.cargo/config
@@ -0,0 +1,3 @@
+# https://github.com/rust-lang/rust/issues/50516
+[target.'cfg(all(debug_assertions, target_arch = "aarch64"))']
+rustflags = ["-C", "llvm-args=-fast-isel"]
diff --git a/.sit/items/ed4bbb0c-2973-4de1-b5f8-648d3011ae86/2UT54I7HQDVAOTKROJO5XHKPAETRWMQF/.authors b/.sit/items/ed4bbb0c-2973-4de1-b5f8-648d3011ae86/2UT54I7HQDVAOTKROJO5XHKPAETRWMQF/.authors
@@ -0,0 +1 @@
+Yurii Rashkovskii <me@yrashk.com>
diff --git a/.sit/items/ed4bbb0c-2973-4de1-b5f8-648d3011ae86/2UT54I7HQDVAOTKROJO5XHKPAETRWMQF/.timestamp b/.sit/items/ed4bbb0c-2973-4de1-b5f8-648d3011ae86/2UT54I7HQDVAOTKROJO5XHKPAETRWMQF/.timestamp
@@ -0,0 +1 @@
+2018-05-07T20:16:50.974Z
diff --git a/...d4bbb0c-2973-4de1-b5f8-648d3011ae86/2UT54I7HQDVAOTKROJO5XHKPAETRWMQF/.type/SummaryChanged b/...d4bbb0c-2973-4de1-b5f8-648d3011ae86/2UT54I7HQDVAOTKROJO5XHKPAETRWMQF/.type/SummaryChanged
diff --git a/.sit/items/ed4bbb0c-2973-4de1-b5f8-648d3011ae86/2UT54I7HQDVAOTKROJO5XHKPAETRWMQF/text b/.sit/items/ed4bbb0c-2973-4de1-b5f8-648d3011ae86/2UT54I7HQDVAOTKROJO5XHKPAETRWMQF/text
@@ -0,0 +1 @@
+Problem: workaround for std::fs:create_dir not failing on existing directory on aarch64, debug
diff --git a/.sit/items/ed4bbb0c-2973-4de1-b5f8-648d3011ae86/JESGGRQLIKCQCF4OKGNVXQSMMWLDBHQW/.authors b/.sit/items/ed4bbb0c-2973-4de1-b5f8-648d3011ae86/JESGGRQLIKCQCF4OKGNVXQSMMWLDBHQW/.authors
@@ -0,0 +1 @@
+Yurii Rashkovskii <me@yrashk.com>
diff --git a/...b5f8-648d3011ae86/JESGGRQLIKCQCF4OKGNVXQSMMWLDBHQW/.prev/2UT54I7HQDVAOTKROJO5XHKPAETRWMQF b/...b5f8-648d3011ae86/JESGGRQLIKCQCF4OKGNVXQSMMWLDBHQW/.prev/2UT54I7HQDVAOTKROJO5XHKPAETRWMQF
diff --git a/.sit/items/ed4bbb0c-2973-4de1-b5f8-648d3011ae86/JESGGRQLIKCQCF4OKGNVXQSMMWLDBHQW/.timestamp b/.sit/items/ed4bbb0c-2973-4de1-b5f8-648d3011ae86/JESGGRQLIKCQCF4OKGNVXQSMMWLDBHQW/.timestamp
@@ -0,0 +1 @@
+2018-05-07T20:16:50.974Z
diff --git a/...d4bbb0c-2973-4de1-b5f8-648d3011ae86/JESGGRQLIKCQCF4OKGNVXQSMMWLDBHQW/.type/DetailsChanged b/...d4bbb0c-2973-4de1-b5f8-648d3011ae86/JESGGRQLIKCQCF4OKGNVXQSMMWLDBHQW/.type/DetailsChanged
diff --git a/.sit/items/ed4bbb0c-2973-4de1-b5f8-648d3011ae86/JESGGRQLIKCQCF4OKGNVXQSMMWLDBHQW/text b/.sit/items/ed4bbb0c-2973-4de1-b5f8-648d3011ae86/JESGGRQLIKCQCF4OKGNVXQSMMWLDBHQW/text
@@ -0,0 +1,5 @@
+std::fs::create_dir does not fail on existing directory on aarch64, when built in debug, leading to failing tests and change in behavior (item with the same name can be created more than once). This issue has been resolved with a workaround handling this special case specifically in this configuration.
+
+However, this is not the most beautiful solution.
+
+Tracking issue filed with Rust: https://github.com/rust-lang/rust/issues/50516
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Problem: workaround for std::fs:create_dir not failing on existing directory on aarch64, debug