Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic jackknife for information imbalance (WIP) #98

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

AldoGl
Copy link
Collaborator

@AldoGl AldoGl commented Sep 13, 2023

Proposed changes

  • A basic estimator for mean and standard deviation of the information imbalance using the Jackknife method

  • A new module and a new class to conveniently manipulate different datasets (eventually it would be a good idea to move here many of the information imbalance methods)

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@AldoGl AldoGl force-pushed the add_inf_imb_jackknife branch from acc8d5e to 7d77c32 Compare September 14, 2023 08:49
@AldoGl AldoGl requested a review from imacocco September 14, 2023 09:05
@AldoGl
Copy link
Collaborator Author

AldoGl commented Sep 14, 2023

@imacocco you already gave a look at the changes. I still need to fix the docs test but let me know if the rest looks ok

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023

Codecov Report

Patch coverage: 92.10% and project coverage change: +0.18% 🎉

Comparison is base (807a60d) 80.10% compared to head (3799b8c) 80.29%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   80.10%   80.29%   +0.18%     
==========================================
  Files          14       15       +1     
  Lines        2393     2431      +38     
==========================================
+ Hits         1917     1952      +35     
- Misses        476      479       +3     
Files Changed Coverage Δ
dadapy/data_sets.py 91.89% <91.89%> (ø)
dadapy/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AldoGl AldoGl force-pushed the add_inf_imb_jackknife branch from 39d1116 to 3799b8c Compare September 14, 2023 09:15
@AldoGl
Copy link
Collaborator Author

AldoGl commented Sep 14, 2023

Tests passing!

@imacocco imacocco merged commit d6244e0 into main Sep 14, 2023
@imacocco imacocco deleted the add_inf_imb_jackknife branch September 14, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants