Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cython version for data_overlap #97

Merged
merged 7 commits into from
Aug 15, 2023
Merged

Conversation

diegodoimo
Copy link
Collaborator

I added a cython implementation of the data_overlap function. This makes this method which was quite slow for large datasets much faster.

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

Patch coverage: 41.86% and project coverage change: -0.36% ⚠️

Comparison is base (3d3c4d4) 80.46% compared to head (8fa530d) 80.10%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
- Coverage   80.46%   80.10%   -0.36%     
==========================================
  Files          14       14              
  Lines        2375     2393      +18     
==========================================
+ Hits         1911     1917       +6     
- Misses        464      476      +12     
Files Changed Coverage Δ
dadapy/_utils/density_estimation.py 74.52% <ø> (ø)
dadapy/_utils/discrete_functions.py 73.36% <ø> (ø)
dadapy/id_discrete.py 79.54% <ø> (ø)
dadapy/metric_comparisons.py 65.87% <22.22%> (-1.97%) ⬇️
dadapy/id_estimation.py 83.59% <63.63%> (-1.33%) ⬇️
dadapy/base.py 85.56% <100.00%> (-0.30%) ⬇️
dadapy/clustering.py 90.85% <100.00%> (+0.07%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@diegodoimo diegodoimo merged commit 807a60d into main Aug 15, 2023
@diegodoimo diegodoimo deleted the data_overlap_cython branch February 2, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants