PaK: solution for singular likelihood hessian and infinite volume shells #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to solve some pathologies that actually result in 'None' values in the density estimated with pak:
presence of shells of infinite volume: here I assign a volume equal to e^300 which is almost the largest floating point number. I didn't want to set it to the largest value possible because the volumes are used in the max likelihood routine, and I didn't test the behavior of using np.inf there;
singularity of the hessian matrix in the optimization of the likelihood: here I added a fixed point step whenever the hessian is singular. This 'bug' is particularly nasty as it leads to none values without specific error messages.