Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed dendrogram representation, some format tests passed #73

Merged
merged 3 commits into from
Jul 19, 2022

Conversation

alexdepremia
Copy link
Collaborator

Proposed changes

I changed the dendrogram in order to better reflect the cluster populations

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • [x ] Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

@alexdepremia alexdepremia requested a review from AldoGl July 18, 2022 07:32
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2022

Codecov Report

Merging #73 (c8fcb00) into main (f290feb) will decrease coverage by 2.44%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   80.61%   78.16%   -2.45%     
==========================================
  Files          10       10              
  Lines        1145     1177      +32     
==========================================
- Hits          923      920       -3     
- Misses        222      257      +35     
Impacted Files Coverage Δ
dadapy/_utils/density_estimation.py 54.83% <0.00%> (-34.96%) ⬇️
dadapy/clustering.py 86.68% <0.00%> (-2.86%) ⬇️
dadapy/density_estimation.py 76.29% <0.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f290feb...c8fcb00. Read the comment docs.

@AldoGl
Copy link
Collaborator

AldoGl commented Jul 18, 2022

I @alexdepremia, I see that you changed many more modules than necessary, 7 instead of 3. If you are ok with it I will remove the unnecessary changes from this PR

@alexdepremia
Copy link
Collaborator Author

Yes, no problem...

@AldoGl AldoGl force-pushed the improved_dendrogram branch from c5292b2 to 9e4c94b Compare July 18, 2022 14:34
@AldoGl
Copy link
Collaborator

AldoGl commented Jul 18, 2022

Hi @alexdepremia I have generated the graphs before and after your change.

before
Screenshot 2022-07-18 at 16 49 16

after
Screenshot 2022-07-18 at 16 52 01

I see some changes in the saddle point locations. Could you explain once again what's the change in essence and how it improves visualisation?

@alexdepremia
Copy link
Collaborator Author

In both (old and new) dendrograms, each cluster is in the middle of a region proportional to its population. In the new one, this region is delimited by the links in which these clusters are involved and, in the case of the first and last clusters, by the beginning and end of the graph.

.

Added labels to dendrogram, moved non-logscale x-limit thus the bar of small clusters becomes visible
lint
@AldoGl AldoGl force-pushed the improved_dendrogram branch from c8b8e41 to ccba546 Compare July 19, 2022 08:04
@AldoGl
Copy link
Collaborator

AldoGl commented Jul 19, 2022

Ok it seems that we can close this PR

@AldoGl AldoGl merged commit 33d150b into main Jul 19, 2022
@AldoGl AldoGl deleted the improved_dendrogram branch July 19, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants