-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed dendrogram representation, some format tests passed #73
Conversation
Codecov Report
@@ Coverage Diff @@
## main #73 +/- ##
==========================================
- Coverage 80.61% 78.16% -2.45%
==========================================
Files 10 10
Lines 1145 1177 +32
==========================================
- Hits 923 920 -3
- Misses 222 257 +35
Continue to review full report at Codecov.
|
I @alexdepremia, I see that you changed many more modules than necessary, 7 instead of 3. If you are ok with it I will remove the unnecessary changes from this PR |
Yes, no problem... |
small fix to be merged
c5292b2
to
9e4c94b
Compare
Hi @alexdepremia I have generated the graphs before and after your change. I see some changes in the saddle point locations. Could you explain once again what's the change in essence and how it improves visualisation? |
In both (old and new) dendrograms, each cluster is in the middle of a region proportional to its population. In the new one, this region is delimited by the links in which these clusters are involved and, in the case of the first and last clusters, by the beginning and end of the graph. . |
Added labels to dendrogram, moved non-logscale x-limit thus the bar of small clusters becomes visible lint
c8b8e41
to
ccba546
Compare
Ok it seems that we can close this PR |
Proposed changes
I changed the dendrogram in order to better reflect the cluster populations
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply.