New ID tutarial jupyter notebbok/ small fixed to compute_id_twoNN #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #66 +/- ##
==========================================
+ Coverage 79.04% 80.57% +1.53%
==========================================
Files 10 10
Lines 1131 1138 +7
==========================================
+ Hits 894 917 +23
+ Misses 237 221 -16
Continue to review full report at Codecov.
|
|
For me the PR can be accepted and merged! |
|
This is ok for me too, @diegodoimo I will squash the commits, rebase, and merge! |
by @diegodoimo I added a big revision to the jupyter notebook tutorial for the ID estimation. I improved the documentation of compute_id_twoNN I added a temporary fix to make the 'compute_id_2NN' run when fraction =1 setting the default algorithm to 'ml' I added assertions to prevent the user to insert wrong values in 'fraction' and 'decimation' kwargs of compute_id_2NN I improved the docstring of compute_id_2NN
AldoGl
force-pushed
the
improve_id_tutorial
branch
from
0b4f6dd to
6b62a9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a big revision to the jupyter notebook tutorial for the ID estimation.
I improved the documentation of compute_id_twoNN
I added a temporary fix to make the 'compute_id_2NN' run when fraction =1 setting the default algorithm to 'ml'
I added assertions to prevent the user to insert wrong values in 'fraction' and 'decimation' kwargs of compute_id_2NN
I imporved the docstring of compute_id_2NN