Pvalues

[imacocco]

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.

Types of changes

What types of changes does your code introduce?

• Cleaned up id_discrete.py by removing pointless and unused functions
• Introduced A-BIDE and A-GRIDE estimators in data.py, at the moment the methods are called with return_ids_kstar_binomial/gride, might opt for abide and agride in the future
• added the related tests
• Set as default the model validation for the binomial id estimator (still using Kolmogorov-Smirnovv test as Epps-Singleton shows SVD convergence problems from time to time)
• minor flake8 fixes

Put an x in the boxes that apply

• [ x ] Bugfix (non-breaking change which fixes an issue)
• [ x ] New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

• [ x ] Lint and unit tests pass locally with my changes
• [ x ] I have added tests that prove my fix is effective or that my feature works

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 71.56863% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 81.38%. Comparing base (24c4c60) to head (c73691b).
Report is 12 commits behind head on main.

❗ Current head c73691b differs from pull request most recent head 5b07199

Please upload reports for the commit 5b07199 to get more accurate results.

Files	Patch %	Lines
dadapy/_utils/id_estimation.py	57.69%	11 Missing ⚠️
dadapy/id_discrete.py	54.54%	10 Missing ⚠️
dadapy/id_estimation.py	84.37%	5 Missing ⚠️
dadapy/data.py	84.21%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
+ Coverage   80.66%   81.38%   +0.72%     
==========================================
  Files          20       20              
  Lines        3330     3293      -37     
==========================================
- Hits         2686     2680       -6     
+ Misses        644      613      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[AldoGl]

Great work @imacocco. I just added some warnings in the Abide notebooks for cells that take a while to run.
The only suggestion for the future would be not to commit notebooks not related to the specific new feature, but this time we can merge those too.
I will rebase and merge!

[AldoGl]

Actually, another issue might be related to the plotting functions in the tests. Do we really need to plot while testing?

[AldoGl]

I force a noninteractive backend in matplotlib in the test modules in order not to slow down the testing process

[AldoGl]

Rebased. Merging after tests pass.