Less regular expressions in bite email #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azumakuniyuki
commented
Jan 15, 2018
| @@ -36,10 +30,11 @@ def headerlist; return []; end | |||
| def scan(mhead, mbody) | |||
| return nil unless mhead | |||
| return nil unless mbody | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
[RuboCop]
Layout/TrailingWhitespace: Trailing whitespace detected.
azumakuniyuki
commented
Jan 15, 2018
| match = 0 | ||
| tryto = [ | ||
| 'Mail could not be delivered', | ||
| # メッセージを配信できません。 |
There was a problem hiding this comment.
[RuboCop]
Style/AsciiComments: Use only ascii symbols in comments.
azumakuniyuki
commented
Jan 15, 2018
| 'Mail could not be delivered', | ||
| # メッセージを配信できません。 | ||
| '=?iso-2022-jp?B?GyRCJWElQyU7ITwlOCRyR1s/LiRHJC0kXiQ7JHMhIxsoQg==?=', | ||
| # メール配信に失敗しました |
There was a problem hiding this comment.
[RuboCop]
Style/AsciiComments: Use only ascii symbols in comments.
|
RuboCop detected 19 issues on 258d4c6 |
azumakuniyuki
added a commit
to sisimai/p5-sisimai
that referenced
this pull request
Jan 24, 2018
azumakuniyuki
added a commit
to sisimai/p5-sisimai
that referenced
this pull request
Jan 24, 2018
azumakuniyuki
added a commit
to sisimai/p5-sisimai
that referenced
this pull request
Jan 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String#=~ in Sisimai::Bite::Email:* will be replaced with
Follow up pull-request #105.