New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGES: Accessor names of Sisimai::Fact, Key names of JSON will be changed #323

Open

azumakuniyuki opened this issue Dec 20, 2024 · 0 comments

Assignees

Labels

Member

azumakuniyuki commented Dec 20, 2024

Change sis.Fact{} member name go-sisimai#8
smtpagent => decodedby
- The value of this member is a sisimai/lhost module name which decoded a bounce message.
- Word Agent is ambiguous
- old name smtpagent could be accessed until v5.5.0
smtpcommand => command
- SMTP is the obvious choice of command when handling bounce emails.
- old name smtpcommand could be accessed until v5.5.0

The text was updated successfully, but these errors were encountered:

azumakuniyuki added the enhancement label

azumakuniyuki self-assigned this

azumakuniyuki added a commit that referenced this issue


          Accessor "smtpagent" has been renamed to "decodedby" #323

This was referenced Dec 20, 2024

Remove old accessors at v5.5.0 #325

Open

Suppress warning message until v5.5.0 #326

Open

azumakuniyuki added a commit that referenced this issue


          Accessor "smtpcommand" has been renamed to "command" #325 #323

12caba5

azumakuniyuki mentioned this issue

Go sisimai compatibility 7e8c #327

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment