-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix and improvement 2021 Nov #442
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and "replycode" at `Sisimai::Lhost::Exim`
azumakuniyuki
commented
Nov 19, 2021
@@ -50,6 +50,13 @@ v4.25.11p2 | |||
Thanks to @vhenon | |||
- Add `rfc3464-41.eml` and `rfc3464-42.eml` | |||
- Remove all the HTML elements from the value of "diagnosticcode". | |||
- Fix a serious bugs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix serious bugs:
azumakuniyuki
commented
Nov 19, 2021
@@ -50,6 +50,13 @@ v4.25.11p2 | |||
Thanks to @vhenon | |||
- Add `rfc3464-41.eml` and `rfc3464-42.eml` | |||
- Remove all the HTML elements from the value of "diagnosticcode". | |||
- Fix a serious bugs: | |||
- Values of `deliverystatus` and `replycode` detected from the message body | |||
did not used at `Sisimai::Lhost::Exim`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did not use
azumakuniyuki
added a commit
that referenced
this pull request
Nov 19, 2021
azumakuniyuki
added a commit
that referenced
this pull request
Nov 19, 2021
azumakuniyuki
added a commit
that referenced
this pull request
Nov 19, 2021
azumakuniyuki
added a commit
that referenced
this pull request
Nov 19, 2021
Import Pull-Request #442
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deliverystatus
andreplycode
detected from the message body did not use atSisimai::Lhost::Exim
.true()
method strictly checks the value ofsmtpcommand
at some classes inSisimai::Reason
. For example, when a detected reason isspamdetected
andvirusdetected
the value ofsmtpcommand
should beDATA
or an SMTP command to be sent afterDATA
.