Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade circleci image to PHP 5.6 #86

Merged
merged 13 commits into from
May 10, 2019
Merged

Downgrade circleci image to PHP 5.6 #86

merged 13 commits into from
May 10, 2019

Conversation

sirbrillig
Copy link
Owner

@sirbrillig sirbrillig commented May 10, 2019

This removes a null coalesce operator that was accidentally added in #83, creating a bug with older versions of PHP.

This also updates the circleci configuration to prevent such regressions from happening in the future.

Fixes #85

@sirbrillig sirbrillig merged commit 00d3158 into master May 10, 2019
@sirbrillig sirbrillig deleted the limit-to-56 branch May 10, 2019 15:40
@GaryJones
Copy link
Contributor

Why was the upgrade to PHP 5.6 needed?

WPCS and PHPCS require PHP >=5.4. I've also just made VIPCS support >=5.4 as well, and was hoping not to have to revert that when pulling in VA.

@sirbrillig
Copy link
Owner Author

Oh, good question. I doubt it was intentional but let me see. Looking at the things added by php 5.5 and php 5.6, the only thing that stands out to me is:

  • Variadic functions using ..., but I could change that to func_get_args as it's just in one place.

I will create a branch that adds PHP 5.4 to the CI and see what happens.

@sirbrillig
Copy link
Owner Author

See #191 where I'll probably spend 5 hours trying to figure out how to get a php 5.4 environment (there's no pre-built docker image on circleci).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not work on php 5.6
2 participants