Beta & canary fixes #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't been able to get beta and canary passing. I believe Glimmer, which is introduced in ember 2.9, is causing these failures. I haven't found any documentation or issues to point me in the direction of fixing the remaining tests. At this point, I suspect the failures may be because ember testing libraries are not compatible with Glimmer. I'll release with the failing test and will circle back when 2.9 is releases with update instructions for developers. |
|
Good plan. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master currently fails in ember-beta and ember-canary ~40 times each. The cause of these failures are....
this.get('parentView')returnsnull. This ticket mentions similar issues. I believe that they continued support for parentView but it's possible we're not referencing the most up to date ember-canary?tooltip-on-elementeverywhere but the tooltip-on-component test (this test is still failing)onTooltipRenderis called twice after the tooltip is destroyed (notes)Result: 1 test failure each instead of 40.