Add targetElement argument
#446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxfierke
reviewed
Jun 25, 2022
There was a problem hiding this comment.
@bendemboski This looks great! CI should be fixed if you rebase off master (looks like Node 12 fell out of "maintained node versions" in browserlist)
Add a `targetElement` argument that's similar to `targetId`, but can specify an HTML element for cases where the target element doesn't have an ID, e.g. HTML rendered by a third-party library.
bendemboski
force-pushed
the
add-target-element-argument
branch
from
029f53d
to
67272c7
Compare
!
|
Sweet, thanks for the quick approval! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
targetElementargument that's similar totargetId, but can specify an HTML element for cases where the target element doesn't have an ID, e.g. HTML rendered by a third-party library.My use case for this is attaching a popover to the currently-selected paragraph in content managed by a CKEditor instance to present options for acting on the paragraph, e.g. block formatting such as alignment.