Remove assign() usage
#439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `assign()` function in Ember.js has been deprecated with v4. This replaces it with the object spread syntax which is compiled away by Babel, if necessary.
maxfierke
approved these changes
Jan 31, 2022
lgtm! I'm assuming the transform is built into any relatively modern ember-cli-babel w/ in the version constraint, but let me know if you know otherwise
yep, that is my understanding too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
assign()function in Ember.js has been deprecated with v4. This replaces it with the object spread syntax which should be compiled away by Babel, if necessary.This is an alternative to and closes #437
/cc @maxfierke