Remove ember-maybe-in-element dependency #407
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ember-maybe-in-element
was used as a quick drop-in replacement forember-wormhole
when the latter became problematic for more recent Ember versions. However, version 2.0.0+ ofember-maybe-in-element
dropped support for Ember < 3.13, which this addon still supports, and uses a Glimmer-component based approach, rather than an AST transform to equivalentin-element
calls. As raised in #406, pinning to 1.0.0 is problematic for folks using newer versions ofember-maybe-in-element
either directly or via popular addons likeember-basic-dropdown
.The most compatible solution, rather than directly importing the AST transform from version 1.0, is to just use
in-element
directly. This results in a small amount of duplication, but I think it's a worthwhile trade-off (duplication that happened during build time anyway, via theember-maybe-in-element
AST transform)