Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ember-maybe-in-element dependency #407

Merged
merged 1 commit into from
Aug 20, 2020

Conversation

maxfierke
Copy link
Collaborator

ember-maybe-in-element was used as a quick drop-in replacement for ember-wormhole when the latter became problematic for more recent Ember versions. However, version 2.0.0+ of ember-maybe-in-element dropped support for Ember < 3.13, which this addon still supports, and uses a Glimmer-component based approach, rather than an AST transform to equivalent in-element calls. As raised in #406, pinning to 1.0.0 is problematic for folks using newer versions of ember-maybe-in-element either directly or via popular addons like ember-basic-dropdown.

The most compatible solution, rather than directly importing the AST transform from version 1.0, is to just use in-element directly. This results in a small amount of duplication, but I think it's a worthwhile trade-off (duplication that happened during build time anyway, via the ember-maybe-in-element AST transform)

@maxfierke maxfierke merged commit 854b01c into master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant