Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ember-maybe-in-element to 2.0.1 #406

Closed
wants to merge 3 commits into from
Closed

Update ember-maybe-in-element to 2.0.1 #406

wants to merge 3 commits into from

Commits on Aug 13, 2020

  1. v3.15.1...v3.20.0 

    # Conflicts:
#	.eslintrc.js
#	.travis.yml
#	CONTRIBUTING.md
#	README.md
#	config/ember-try.js
    @andreyfel
    andreyfel committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    e0e3d66 View commit details
    Browse the repository at this point in the history

  2. Update ember-maybe-in-element and other deps 

    ember-maybe-in-element needs to be updated to ^2.0.1, so, it can use
latest {{in-element}} API from Ember 3.20 and don't throw deprecation
about using deprecated private {{-in-element}} API.

Update other dependencies as well.
    @andreyfel
    andreyfel committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    bfcee39 View commit details
    Browse the repository at this point in the history

  3. Drop support of Ember < 3.13 

    Ember 3.13 is a minimum supported version of
ember-maybe-in-element@2.0.1.

Fix eslint errors and use this.foo instead of this.get('foo').
Since this syntax is supported since Ember 3.1 this change is
compatible with current supported versions >= 3.13.
    @andreyfel
    andreyfel committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    8ba41ed View commit details
    Browse the repository at this point in the history