Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array.includes -> Array.indexOf for IE11 #396

Merged
merged 1 commit into from
May 14, 2020
Merged

Array.includes -> Array.indexOf for IE11 #396

merged 1 commit into from
May 14, 2020

Conversation

raido
Copy link
Contributor

@raido raido commented May 13, 2020

Addresses: #310

Symbol issue from for..of loop mention in that ticket has been solved in previous releases already.

maxfierke
maxfierke approved these changes May 14, 2020
View reviewed changes
Copy link
Collaborator

@maxfierke maxfierke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! will tag a release when I have time today

@maxfierke maxfierke self-assigned this May 14, 2020
@maxfierke maxfierke merged commit 283ad80 into sir-dunxalot:master May 14, 2020
@raido raido deleted the array-includes-ie11 branch May 14, 2020 07:54
@raido
Copy link
Contributor Author

raido commented May 14, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxfierke maxfierke maxfierke approved these changes

Assignees

@maxfierke maxfierke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raido @maxfierke