move ember-tether to dependencies

[samdemaeyer]

Fix for issue #165

Ember-tether is needed for this addon, but it will not be installed when you do a fresh install and don't have the dependency installed in your local project.
Moving it from devDependencies to dependencies should make sure it's installed.

[tsteuwer]

We should not be using the beta release. I would revert that change

[samdemaeyer]

@tsteuwer, sure, NP. 👍

[jrjohnson]

@sir-dunxalot sorry for the ping - any reason not to merge this?

[sir-dunxalot]

@jrjohnson. Sorry for the lack of response. I was traveling a lot and have yet to catch up with ember-tooltips activity from the last two months. This is mergeable and I will endeavor to get back up-to-speed with updated here and release this fix ASAP.

[allthesignals]

Please merge this...

[samdemaeyer]

@sir-dunxalot?? 😅 any news on this?

[FredUK]

I have just tried 2.9.0 to fix this issue and the same on #214 .It now installs fine however when the tooltip is about to be rendered an exception is thrown complaining about ember-tether. Is there anything else we should be doing to get it to work or should it just work?

[sir-dunxalot]

Tether is killing me...

There may be a serious issue using the library here. However, the test suite is not erroring in Travis so I don't have a reproducible example for this to hand. @FredUK Are you able to share any of your app shown above or perhaps can create a quick repo that shows the failure? I will try to do the same my end. If this issue is determined to be existing outside your local environment, let's create a separate issue for this and continue the conversation there.

[dknutsen]

I'm seeing the same thing as @FredUK, just freshly installed ember tooltips in a fairly new ember project (see version info below). ember tooltips is at 2.9.0. I put the following in a template:

  <div class="form-group ">
    <label class="col-sm-4 control-label">
      Set Password Webhook
      <span id="passwordWebhookHelp" class="glyphicon glyphicon-question-sign"></span>
    </label>
    <div class="col-sm-7">
      {{input class="form-control" type="text" value=model.organization.reset_password_webhook_url placeholder="e.g. http://abc.com/setpassword (optional)"}}
    </div>
  </div>
  {{#tooltip-on-element target='#passwordWebhookHelp'}}
    This facility allows organizations to control their own, customized workflows for setting passwords.
  {{/tooltip-on-element}}

App version info:

DEBUG: -------------------------------
DEBUG: Ember             : 2.13.4
DEBUG: Ember Data        : 2.14.10
DEBUG: jQuery            : 3.2.1
DEBUG: Ember Bootstrap   : 1.0.0-rc.2
DEBUG: Ember Simple Auth : 1.4.0
DEBUG: -------------------------------

[dknutsen]

If I install ember-tether v1.0.0-beta.0 alongside ember-tooltips it works fine