Remove compass boilerplate #177
Conversation
| @import 'compass-boilerplate-vendor/html5bp'; | ||
| @import 'compass-boilerplate'; | ||
| @import 'vendor/normalize'; | ||
| @import 'vendor/html5bp'; |
There was a problem hiding this comment.
As a quick fix, I have moved the normalize and html5bp files into this project. These files are added in this PR below.
| @include flex-direction(column); | ||
| justify-content: center; | ||
| align-items: center; | ||
| flex-direction: column; |
There was a problem hiding this comment.
I'm making the assumption that ember developer are using up-to-date browsers, which don't need vendor prefixes. If we want to make our dummy app more cross-browser friendly, we could use ember-cli-postcss. I think that's outside the scope of this PR.
There was a problem hiding this comment.
#178 adds postcss and autoprefixer to the dummy app to accommodate for these changes.
| @@ -1,6 +1,5 @@ | |||
| @import 'compass-boilerplate-vendor/normalize'; | |||
There was a problem hiding this comment.
Note: all the changes in this file only affect the dummy app.
| @@ -0,0 +1,245 @@ | |||
| /*! HTML5 Boilerplate v5.2.0 | MIT License | https://html5boilerplate.com/ */ | |||
There was a problem hiding this comment.
File copied from compass-boilerplate.
| @@ -0,0 +1,424 @@ | |||
| /*! normalize.css v3.0.3 | MIT License | github.com/necolas/normalize.css */ | |||
There was a problem hiding this comment.
File copied from compass-boilerplate.
|
When this PR is merged, we need to redeploy the dummy app: git checkout master # make sure you're on master branch
ember github-pages:commit --message "Some commit message" # Builds the app
git push origin gh-pages:gh-pages # Deploys the app |
This PR removes the dependency on the
compass-boilerplatelibrary, which was causing this addon's test suite to fail. Whilst thecompass-boilerplatetest suite was able to be fixed to a passing state, various environments upgrading their node versions have appear to bring incompatibilities causing consuming app's test suites to fail. Specifically, the following error appeared in Ember CLI and Travis builds of this addon:By removing
compass-boilerplatefrom this project, the test suite is restored to a passing build.The outputted CSS of the dummy app, which was what we used
compass-boilerplatefor, is styled the same. We're just writing thescssin a more explicit way.