Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warnings with Ember 3.20 #402

Closed
boris-petrov opened this issue Jul 18, 2020 · 5 comments · Fixed by #403
Closed

Deprecation warnings with Ember 3.20 #402

boris-petrov opened this issue Jul 18, 2020 · 5 comments · Fixed by #403
Assignees
@maxfierke

Comments

@boris-petrov
Copy link

This addon uses ember-maybe-in-element 0.4.0 which uses the as-of-Ember-3.20 deprecated -in-element. That's printed as warnings in the console when running ember serve. Simply updating ember-maybe-in-element to 1.0.0 should fix the issue.

Thanks for the great addon!
@maxfierke maxfierke self-assigned this Jul 19, 2020
@maxfierke
Copy link
Collaborator

Awesome, thanks for the heads up! Will take a look at that this week.

maxfierke added a commit that referenced this issue Jul 22, 2020
@maxfierke
Upgrade ember-maybe-in-element to ^1.0.0
114b9d7 
Resolves a deprecation warning in Ember 3.20

Closes #402
@maxfierke maxfierke mentioned this issue Jul 22, 2020
Merged
@raido
Copy link
Contributor

raido commented Aug 12, 2020

@maxfierke any update on this?

@maxfierke
Copy link
Collaborator

@boris-petrov it was breaking CI for some earlier Ember versions, but will look at relaxing the constraint a bit tonight to allow for a greater range of versions

@raido
Copy link
Contributor

raido commented Aug 13, 2020

The maybe-in-element addon has recent v2 release as well.

maxfierke added a commit that referenced this issue Aug 14, 2020
@maxfierke
Upgrade ember-maybe-in-element to ^1.0.0
95c575e 
Resolves a deprecation warning in Ember 3.20

Closes #402
@maxfierke
Copy link
Collaborator

This has been addressed in v3.4.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxfierke maxfierke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade ember-maybe-in-element to ^1.0.0 sir-dunxalot/ember-tooltips
3 participants
@boris-petrov @maxfierke @raido