Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation and tests to use Octane features #389

Closed
1 task
maxfierke opened this issue Dec 27, 2019 · 0 comments
Closed
1 task

Update documentation and tests to use Octane features #389

maxfierke opened this issue Dec 27, 2019 · 0 comments
Assignees
@maxfierke
Labels
3.x ember-tooltips Release series 3.x enhancement good-for-new-contributor

Comments

@maxfierke
Copy link
Collaborator

Ember Octane has been released, but the documentation for ember-tooltips is not inline with the Ember Octane best practices. It should be updated to reflect these, for example.

  • {{curly-components with="attributes"}} to <TagComponents @with="attributes">

Please suggest others that you notice
@maxfierke maxfierke added enhancement 3.x ember-tooltips Release series 3.x good-for-new-contributor labels Dec 27, 2019
@maxfierke maxfierke self-assigned this Dec 27, 2019
maxfierke added a commit that referenced this issue Jan 20, 2020
@maxfierke
Update README to follow Octane conventions
03b5e07 
Fixes #389
maxfierke added a commit that referenced this issue Jan 20, 2020
@maxfierke
Update README to follow Octane conventionsFixes #389
5831c78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxfierke maxfierke

Labels
3.x ember-tooltips Release series 3.x enhancement good-for-new-contributor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maxfierke