Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TOML for overrides, add some special subjects #106

Merged
merged 9 commits into from
Jan 7, 2025
Merged

Use TOML for overrides, add some special subjects #106

merged 9 commits into from
Jan 7, 2025

Conversation

psvenk
Copy link
Member

@psvenk psvenk commented Dec 15, 2024

Use a TOML file to make the overrides file more human-writable, and start it with some special subjects for spring 2025.

@Alwinfy
Copy link
Collaborator

Alwinfy commented Dec 15, 2024

toml

@cjquines
Copy link
Member

ah, toml, up there with json and yaml. my recent fascination is kdl. insert xkcd comic about standards, though the fact that toml is a python builtin these days is a plus

@dtemkin1
Copy link
Collaborator

the TOML decoder in the toml packager isn't able to decode arrays of mixed types, which means it can't decode eg. manual section entries. Since we're on python 3.8 and can't use the native tomllib library, we might want to use the package its based on tomli?

@psvenk
Copy link
Member Author

psvenk commented Dec 15, 2024

I was hesitant to use TOML for the same reasons, but I thought it's a sufficiently established standard since tomllib exists now (see also: #81 (review)).

@dtemkin1 Good point; I'll switch to tomli version 2.0.1 (the latest supporting Python 3.7).

@psvenk psvenk changed the title Use TOML for overrides, add Course 6 special subjects Use TOML for overrides, add special subjects Dec 15, 2024
@dtemkin1
Copy link
Collaborator

Also we might want to consider creating a JSON schema for the override files, to make it easier for manual entry?

@gabrc52 gabrc52 changed the title Use TOML for overrides, add special subjects Use TOML for overrides, add some special subjects Dec 16, 2024
@psvenk psvenk requested a review from dtemkin1 January 6, 2025 21:42
Copy link
Collaborator

@dtemkin1 dtemkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! We might want to email out to UG admins and ask them to send us their special subject data soon

@psvenk psvenk merged commit bb59bb0 into main Jan 7, 2025
3 checks passed
@psvenk psvenk deleted the overrides branch January 7, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants