Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize and secure temp file creation #2

Closed
wants to merge 1 commit into from
Closed

Modernize and secure temp file creation #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion c3r-sdk-core/src/main/java/com/amazonaws/c3r/io/sql/TableGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import com.amazonaws.c3r.config.TableSchema;
import com.amazonaws.c3r.exception.C3rRuntimeException;
import com.amazonaws.c3r.utils.FileUtil;
import java.nio.file.Files;
import lombok.NonNull;

import java.io.File;
Expand Down Expand Up @@ -71,7 +72,7 @@ public static SqlTable initTable(final TableSchema schema, final ColumnHeader no
*/
static File initTableFile(@NonNull final String tempDir) {
try {
final File tempDbFile = File.createTempFile("c3rTmp", ".db", new File(tempDir));
final File tempDbFile = Files.createTempFile(new File(tempDir).toPath(), "c3rTmp", ".db").toFile();
// Set 600 file permissions
FileUtil.setOwnerReadWriteOnlyPermissions(tempDbFile);
// Ensure file is cleaned up when JVM is closed.
Expand Down