Reverse breaking sio2jail change #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5bebd72.
MasloMaslane
force-pushed
the
reverse-si2jail-change
branch
from
011b503 to
3ec639a
Compare
j4b6ski
added a commit
to j4b6ski/sinol-make
that referenced
this pull request
Jan 19, 2025
This reverts commit 28abda2.
MasloMaslane
pushed a commit
that referenced
this pull request
Jan 20, 2025
* Revert "Reverse breaking sio2jail change (#279)" This reverts commit 28abda2. * bump version * Run sio2jail self-check with Sio2jailExecutor We currently don't pass enough cmdline arguments to sio2jail self-check, which makes it fail erroneously on some system configurations. This change prevents that from happening, by using Sio2jailExecutor to run the self check. Notably this change required adding the original cmdline to ExecutionResult for logging errors later - this feels like a leaky abstraction, but that class actually already carries the process exit signal and stderr. Also improved sio2jail related error messages for better user experience. * s/test/self-check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.