Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pug 2.0 Upgrade #133

Closed
wants to merge 10 commits into from
Closed

Pug 2.0 Upgrade #133

wants to merge 10 commits into from

Conversation

jeremywiebe
Copy link

@jeremywiebe jeremywiebe commented Dec 27, 2016

Convert to using Pug 2 (beta 6). This is basically just template file renames along with references to them. This leaves no legacy .jade file support which might be desirable to make it easier to continue to use terraform with existing codebases.

❓ Looking for your thoughts on how to approach supporting "legacy" .jade files if you think it's worth implementing in this PR right away.

  • Currently one unit test fails. Looks like pug is reporting the wrong line number (should be 3 but it's reporting 20).

@sintaxi
Copy link
Owner

sintaxi commented Dec 29, 2016

Jade is small, fast, robust, ubiquitous, well written, and stable. What is there not to like?

At this time I think it is best for harp & terraform to continue to use jade. Jade is an extremely good and stable library that has served harp very, very well. The benefits of a name-change are virtually non-existent and there are absolutely enormous drawbacks.

  • A change would break what I can only guess would be hundreds of thousands of existing harp projects.
  • A change makes harp docs and other online guides and blog posts obsolete.
  • A change will confuse a huge number of developers. Jade is widespread across multiple languages.
  • Apart from users having to rename all their templates a switch to pug would cause further incompatibility.

Thanks for the PR however I have no intention on forcing this change onto harp users.

@jeremywiebe
Copy link
Author

jeremywiebe commented Dec 29, 2016

Thanks for taking time to reply @sintaxi

Jade is small, fast, robust, ubiquitous, well written, and stable. What is there not to like?

I love Jade. However, Jade has been deprecated and is now called Pug. Is your intention that you continue running on Jade 1.x indefinitely? What happens if a security issue is discovered in Jade, right now v1 would have to be forked and maintained under a new name anyways, why not embrace Pug before it's an emergency?

Would you be open to changes to this PR that introduced Jade 2.0 (I mean Pug 2.0) but left all the template extensions as .jade? This moves harp to the newer, maintained version of Jade Pug but causes very little churn for existing users as they upgrade.

I also noticed that this Issue was just raised. #132

Would that be a better place to discuss the merits of a version upgrade?

@jeremywiebe jeremywiebe deleted the pug branch January 17, 2017 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants