-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pug 2.0 Upgrade #133
Pug 2.0 Upgrade #133
Conversation
Jade is small, fast, robust, ubiquitous, well written, and stable. What is there not to like? At this time I think it is best for harp & terraform to continue to use jade. Jade is an extremely good and stable library that has served harp very, very well. The benefits of a name-change are virtually non-existent and there are absolutely enormous drawbacks.
Thanks for the PR however I have no intention on forcing this change onto harp users. |
Thanks for taking time to reply @sintaxi
I love Jade. However, Jade has been deprecated and is now called Pug. Is your intention that you continue running on Jade 1.x indefinitely? What happens if a security issue is discovered in Jade, right now v1 would have to be forked and maintained under a new name anyways, why not embrace Pug before it's an emergency? Would you be open to changes to this PR that introduced Jade 2.0 (I mean Pug 2.0) but left all the template extensions as I also noticed that this Issue was just raised. #132 Would that be a better place to discuss the merits of a version upgrade? |
Convert to using Pug 2 (beta 6). This is basically just template file renames along with references to them. This leaves no legacy
.jade
file support which might be desirable to make it easier to continue to use terraform with existing codebases.❓ Looking for your thoughts on how to approach supporting "legacy"
.jade
files if you think it's worth implementing in this PR right away.3
but it's reporting20
).