-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide source maps where available #74
Comments
Very cool. Wow, the demand for source maps is pretty crazy. |
Stylus has an issues for it too |
👍 |
1 similar comment
+1 |
FTFY ;) |
CoffeeScript and Less SourceMap support is added in my fork, will pull-request after my another pull-request is merged. |
Holy cow thats rad! |
👍 awesome job @kebot |
@sintaxi Do you reviewed my pull-request of the support of in memory cache, the source map support is based on it? |
👍 |
Is there any progress on this? |
+1 |
+1 |
Hate to just tack on a +1. I tried Harp and love the simplicity but source maps is the feature which prevents me from switching from Gulp. |
Same here. Minification of JS and CSS without source maps doesn't work when you need to debug ;-) |
Just wanted to run this terraform PR past the group to see if I'm on the right path before implementing in the harp project, too. Once I get into Harp, I'm struggling between the following two choices:
Once we have the .scss maps proofed out, would we finish adding .less/.styl maps to terraform.git, or all available sourcemapped extensions, or just roll out the one for harp.git? |
@sintaxi will have the final word on this, but my expectation would be:
Our goal would be to have them for all preprocessors, but we wouldn’t be opposed to starting with Sass and tagging a release of Terraform, if that was significantly easier. |
By the way, I ended up writing my own middleware that compiles the usual suspects (sass, less, stylus, coffeescript, babel, etc..) and does sourcemaps too: https://github.com/davej/piggy-in-the-middle |
Ok Harp team, please have a look at the sourcemap pull requests I've opened in Harp and Terraform and advise on how you'd like to see them improved in order to be accepted. Our dev team makes heavy use of Harp and we're really looking forward to making use of |
* 'master' of github.com:sintaxi/terraform: (22 commits) version bump v1.0.0 .. Version bump for reference in Harp Sourcemaps support for stylus stylesheets Need to update Stylus to 0.53.0 in order to receive source maps support. Had to change how the custom error generation was being handled (styl.js, line 21) Adding sourcemaps for .less stylesheets Adding sourcemaps for .sass stylesheets Adding sourcemaps for .scss in order to facilitate sourcemap support in Harp: sintaxi/harp#74 Version bump v0.13.2 Adds patch updates for Node-sass and PostCSS `getCurrent` handles dots in the path. Add a failing test for `getCurrent` with a dotted path. Updates CI targets Version bump v0.13.1 Updates Autoprefixer Updates Node-sass Removes Node v0.10.x from CI Version bump v0.13.0 Updates dependencies, drops Node v0.10.x support add and require lodash to templates ... # Conflicts: # lib/terraform.js # package.json
This is a bit of a bummer :( I just really fell in love with Harp when I found out that my coffeescripts doesn't have source maps mapped to their minified JS counterparts :( |
+1 |
Harp should support source maps where available.
http://www.html5rocks.com/en/tutorials/developertools/sourcemaps/
This is landing in Less 1.5
less/less.js#1050
CoffeeScript 1.6
TypeScript supports it
Jade has an issue, but...
pugjs/pug#941
This boils down to generating a second file and referencing it via header.
The text was updated successfully, but these errors were encountered: