Merge pull request #32 from sevonj/fix-empty-pgen

Fix: crash on empty pgen chunk
sinshu · Jan 11, 2025 · 2746a5f · 2746a5f
2 parents 0d174d8 + 10a74a4
commit 2746a5f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/rustysynth/src/generator.rs b/rustysynth/src/generator.rs
@@ -26,7 +26,7 @@ impl Generator {
         reader: &mut R,
         size: usize,
     ) -> Result<Vec<Generator>, SoundFontError> {
-        if size % 4 != 0 {
+        if size == 0 || size % 4 != 0 {
             return Err(SoundFontError::InvalidGeneratorList);
         }
 

diff --git a/rustysynth/src/sample_header.rs b/rustysynth/src/sample_header.rs
@@ -51,7 +51,7 @@ impl SampleHeader {
         reader: &mut R,
         size: usize,
     ) -> Result<Vec<SampleHeader>, SoundFontError> {
-        if size % 46 != 0 {
+        if size == 0 || size % 46 != 0 {
             return Err(SoundFontError::InvalidSampleHeaderList);
         }
 

diff --git a/rustysynth/src/zone_info.rs b/rustysynth/src/zone_info.rs
@@ -28,7 +28,7 @@ impl ZoneInfo {
         reader: &mut R,
         size: usize,
     ) -> Result<Vec<ZoneInfo>, SoundFontError> {
-        if size % 4 != 0 {
+        if size == 0 || size % 4 != 0 {
             return Err(SoundFontError::InvalidZoneList);
         }