Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Spy passes through calling with new #1626

Merged
merged 7 commits into from
Dec 7, 2017
Merged

[feature] Spy passes through calling with new #1626

merged 7 commits into from
Dec 7, 2017

Commits on Dec 6, 2017

  1. [feature] Spy passes through calling with new 

    This changes the spy behavior so that if the spy is `calledWithNew()` then
the original function will also get called with `new`.

This was throwing an error if you tried spying on an ES6 class object.
    @ProLoser
    ProLoser authored Dec 6, 2017
    Configuration menu
    Copy the full SHA
    6b8b8b3 View commit details
    Browse the repository at this point in the history

  2. fixed PR 1626 build errors

    @ProLoser
    ProLoser authored Dec 6, 2017
    Configuration menu
    Copy the full SHA
    e2efc65 View commit details
    Browse the repository at this point in the history

  3. Merged thisCall.calledWithNew() if-statements

    @ProLoser
    ProLoser authored Dec 6, 2017
    Configuration menu
    Copy the full SHA
    2f9b8f2 View commit details
    Browse the repository at this point in the history

  4. Added "spy passes 'new' to underlying function" test 

    I hope this is a decent enough way to unit test this behavior
    @ProLoser
    ProLoser authored Dec 6, 2017
    Configuration menu
    Copy the full SHA
    3d26922 View commit details
    Browse the repository at this point in the history

  5. Removed trailing space in spy.js

    @ProLoser
    ProLoser authored Dec 6, 2017
    Configuration menu
    Copy the full SHA
    f01fb29 View commit details
    Browse the repository at this point in the history

  6. Fixed lint errors in spy-test.js

    @ProLoser
    ProLoser authored Dec 6, 2017
    Configuration menu
    Copy the full SHA
    3526a6b View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2017

  1. Extract method from prototype and make test easier to debug 

    Using a named function makes it far easier to follow what is happening
in a debugger.
    @fatso83
    fatso83 committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    478e58a View commit details
    Browse the repository at this point in the history