Add documentation for sinon.assert.match #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertknight
reviewed
Nov 9, 2016
|
|
||
| describe('example', function(){ | ||
| it('should fail for mismatching strings', function() { | ||
| sinon.assert.match('hello', 'world'); |
There was a problem hiding this comment.
Perhaps it would be worth using an example involving fuzzy matching, since this is what makes sinon.match useful compared to say, node or chai assertions?
eg:
// Test value of `x` property, ignore `y`
sinon.assert.match({x:1,y:2}, sinon.match({x:1}))There was a problem hiding this comment.
I've pushed a new commit with an improved example based on your feedback @robertknight
mroderick
force-pushed
the
add-documentation-for-assert.match
branch
from
23bc604 to
4875211
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for master, it is a solution to #1147.