Add test for issue #1026 #1030
Merged
Add test for issue #1026 #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I merge this before we have a working fix? That would leave a broken |
I would say no, this is a minor issue that's been around for years. |
|
|
||
| assert.isArray(stubbedObject.watch.args); | ||
|
|
||
| if (oldWatch) { |
There was a problem hiding this comment.
None of this is guaranteed to be reached it the test fails.
mroderick
force-pushed
the
add-test-for-issue-1026
branch
2 times, most recently
from
22734c1 to
56edcec
Compare
|
@fatso83 @fearphage I've added a few commits to this, I believe it is complete and fixes #1026. If you agree, then I'd like to squash the |
|
Once we merge this, we will have to port the fix to |
|
Morgan, were you supposed to squash the review commit before I merged this? |
The previous test only worked because of a faulty implementation in our source, once that is fixed, this test will fail, because we walk ALL own properties. Instead, this test has been rewritten to ensure that each property is only examined once, by looking at what property names have been used.
This is the fix proposed by @ajdaniel in [1]. Now that we have corrected the faulty "does not walk the same property twice" test in the previous commit, this solution does cause that test to (incorrectly) fail. [1]: sinonjs#1026
|
Rebased in my branch: $ git remote add fatso83 git@github.com:fatso83/sinon.git
$ git fetch fatso83
$ git log --oneline -n3 fatso83/add-test-for-issue1026
2f04613 Fix #1026: stub watch method on object
33d7326 Fix invalid test for "does not walk the same property twice"
9d6ae3b Add test for issue #1026
$ git reset --hard fatso83/add-test-for-issue-1026 |
mroderick
force-pushed
the
add-test-for-issue-1026
branch
from
56edcec to
2f04613
Compare
|
Thanks @fatso83, I've applied the rebased version from your branch |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This is a PR for v1.17 branch, it adds a failing test case for #1026
How to verify - mandatory
npm installnpm test