Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix respond() & readystatechange process flow #184

Merged

Commits on May 14, 2021

  1. codejedi365-fix-readystatechange-flow > add test

    \### Rationale
    Added issue replication test for issue sinonjs#165 where readystatechange
    event is occuring after loadend event occurs.
    codejedi365 committed May 14, 2021
    Configuration menu
    Copy the full SHA
    1a252a2 View commit details
    Browse the repository at this point in the history
  2. codejedi365-fix-readystatechange-flow > resolved

    \### Rationale
    The code was using fall through logic which caused the extra
    readystatechange event to be thrown after the loadend event.  The logic
    was there to delinate from a finished XHR request and throw the loadend
    but not to stop processing. Note that a readystatechange did have to be
    added prior to the loadend otherwise some requests would not resolve
    and it was noticeable through other unit-tests. This commit has all
    passing tests to include the one designed to replicate the issue of
    
    Resolves sinonjs#165
    codejedi365 committed May 14, 2021
    Configuration menu
    Copy the full SHA
    1dcef93 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2021

  1. codejedi365-fix-readystatechange-flow > improve codestyle

    ### Rationale
    Ensure logic is clear by avoiding empty return statements and
    fall-through logic
    codejedi365 committed May 20, 2021
    Configuration menu
    Copy the full SHA
    183eed9 View commit details
    Browse the repository at this point in the history