adding support for custom network args #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
|
First of all thank you for the PR 😄 I've checked the example and I have some doubts. I'll try to illustrate them by commenting on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will close #60 @scicco you can follow the example here: https://github.com/singularityhub/singularity-compose-examples/tree/master/v2.0/custom-network
I think part of the trouble was the entrypoint had an envar, evaluated from the host is not going to work, so I added a startscript instead. So this PR is adding support for custom network args primarily.
Give that a shot, show me what doesn't work (and I'll fix it up) and we can go from there!
Signed-off-by: vsoch vsoch@users.noreply.github.com