Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not log a warning when the errorBoundaryClass is provided #171

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Do not log a warning when the errorBoundaryClass is provided #171

merged 1 commit into from
Jun 16, 2023

Conversation

nickbosland
Copy link
Contributor

When a parcel is mounted it checks if errorBoundary is set or it implements the componentDidCatch function, if those are not available it will log a warning to the console. This warning is always logged when you use the errorBoundaryClass property.

It is possible to work around this by setting suppressComponentDidCatchWarning but that feels a bit weird, so this PR fixes this issue by include an additional check if the errorBoundaryClass is set

joeldenning
joeldenning approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@joeldenning joeldenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@joeldenning joeldenning merged commit 017b7f4 into single-spa:main Jun 16, 2023
@joeldenning
Copy link
Member

Released in https://github.com/single-spa/single-spa-react/releases/tag/v5.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeldenning joeldenning joeldenning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickbosland @joeldenning